skpkg: run package update on the repository and support python 3.14 while dropping 3.11#162
Open
zmx27 wants to merge 3 commits intodiffpy:migrationfrom
Open
skpkg: run package update on the repository and support python 3.14 while dropping 3.11#162zmx27 wants to merge 3 commits intodiffpy:migrationfrom
zmx27 wants to merge 3 commits intodiffpy:migrationfrom
Conversation
Author
|
@sbillinge ready for review. I also ran pre-commit with the newly added |
sbillinge
reviewed
Mar 26, 2026
Contributor
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
Looks great. Please see comments
| "m2r2", | ||
| ] | ||
|
|
||
| autodoc_mock_imports = [ |
Contributor
There was a problem hiding this comment.
I am guessing we may need to keep this unless there is a reason you think not
| # |version| and |release|, also used in various other places throughout the | ||
| # built documents. | ||
|
|
||
| fullversion = version(project) |
Contributor
There was a problem hiding this comment.
Please check that full version is getting defined somewhere
| [tool.codespell] | ||
| exclude-file = ".codespell/ignore_lines.txt" | ||
| ignore-words = ".codespell/ignore_words.txt" | ||
| skip = "*.cif,*.dat,*.cc,*.h" |
Contributor
There was a problem hiding this comment.
We probably want to keep the .cc and .h here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #145