Fix Microsoft login with signing keys that omit alg - #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft login completed its token exchange but failed while loading signing keys. Microsoft's public RSA JWKs omit the optional
algmember; Better Auth 1.7.3 passes that missing value toimportJWK, which throws a TypeError.Use JOSE's remote JWKS resolver against the fixed Microsoft endpoint. RS256 remains pinned, and existing signature, nonce, audience, issuer, expiry and tenant/object identity checks remain intact. The Microsoft mock now omits
alg, matching the production response.Validation: reproduced the exact importer error using only Microsoft's public keys; the updated fixture failed before the fix.
pnpm checkpasses all 160 tests, including valid Microsoft login and forged-token rejection.pnpm packages:verifypassed.