Skip to content

chore(deps): group the node-datachannel family in Renovate and update it to v0.33.4 #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nedtwigg merged 4 commits into from
Sep 14, 2026
+75 −67
Merged

chore(deps): group the node-datachannel family in Renovate and update it to v0.33.4 #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
593dc5d
chore(renovate): bump the node-datachannel prebuild family as one group
dormouse-bot Sep 14, 2026
8c6d3f4
chore(deps): update the node-datachannel family to v0.33.4
nedtwigg Sep 14, 2026
fadb34c
chore(renovate): say the grouped node-datachannel PR still needs a di…
nedtwigg Sep 14, 2026
cddbfd6
chore(renovate): name both node-datachannel failure modes, not just t…
nedtwigg Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,14 @@
"groupSlug": "xterm",
"separateMajorMinor": false
},
{
"description": "node-datachannel publishes one prebuilt package per platform from one repository at one version, and the sidecar declares all six beside the core package. website/scripts/generate-deps.js describes the five platforms pnpm did not install from whichever sibling it did — matching on the exact version string — and throws when no sibling sits at that version, so a prebuild-only bump fails the `Dependency disclosure is current` CI step and cannot go green on its own (docs/specs/security-supply-chain.md -> Disclosure). The core package belongs in the group too: it declares its own optionalDependencies at its own version and the addon resolves the platform binary relative to its own directory, so bumping the platform packages alone ships a prebuild nothing loads. A core-only bump does not throw — the prebuild then resolves twice, once from the root pin and once nested under the new core, and the disclosure regenerates with every prebuild listed at both versions. The grouped PR still arrives red: Renovate does not run the generator, so website/src/data/dependencies-npm.json is stale until someone commits `node website/scripts/generate-deps.js`. That red is expected and is one commit to clear — unlike a prebuild-only bump, which throws before it can produce a snapshot at all",
"matchManagers": ["npm"],
"matchPackageNames": ["node-datachannel", "@node-datachannel/**"],
"groupName": "node-datachannel",
"groupSlug": "node-datachannel",
"separateMajorMinor": false
},
{
"description": "@types/node must track the pinned Node runtime major and must not expose APIs newer than the runtime we bundle",
"matchManagers": ["npm"],
Expand Down
106 changes: 53 additions & 53 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions standalone/sidecar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@
},
"dependencies": {
"detect-libc": "2.1.2",
"node-datachannel": "0.33.2",
"node-datachannel": "0.33.4",
"node-pty": "1.2.0-beta.15"
},
"optionalDependencies": {
"@node-datachannel/darwin-arm64": "0.33.2",
"@node-datachannel/darwin-x64": "0.33.2",
"@node-datachannel/linux-arm64-gnu": "0.33.2",
"@node-datachannel/linux-x64-gnu": "0.33.2",
"@node-datachannel/win32-arm64-msvc": "0.33.2",
"@node-datachannel/win32-x64-msvc": "0.33.2"
"@node-datachannel/darwin-arm64": "0.33.4",
"@node-datachannel/darwin-x64": "0.33.4",
"@node-datachannel/linux-arm64-gnu": "0.33.4",
"@node-datachannel/linux-x64-gnu": "0.33.4",
"@node-datachannel/win32-arm64-msvc": "0.33.4",
"@node-datachannel/win32-x64-msvc": "0.33.4"
}
}
14 changes: 7 additions & 7 deletions website/src/data/dependencies-npm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,42 +22,42 @@
},
{
"name": "@node-datachannel/darwin-arm64",
"version": "0.33.2",
"version": "0.33.4",
"license": "MPL 2.0",
"author": "Murat Doğan, Paul-Louis Ageneau",
"homepage": "https://github.com/murat-dogan/node-datachannel"
},
{
"name": "@node-datachannel/darwin-x64",
"version": "0.33.2",
"version": "0.33.4",
"license": "MPL 2.0",
"author": "Murat Doğan, Paul-Louis Ageneau",
"homepage": "https://github.com/murat-dogan/node-datachannel"
},
{
"name": "@node-datachannel/linux-arm64-gnu",
"version": "0.33.2",
"version": "0.33.4",
"license": "MPL 2.0",
"author": "Murat Doğan, Paul-Louis Ageneau",
"homepage": "https://github.com/murat-dogan/node-datachannel"
},
{
"name": "@node-datachannel/linux-x64-gnu",
"version": "0.33.2",
"version": "0.33.4",
"license": "MPL 2.0",
"author": "Murat Doğan, Paul-Louis Ageneau",
"homepage": "https://github.com/murat-dogan/node-datachannel"
},
{
"name": "@node-datachannel/win32-arm64-msvc",
"version": "0.33.2",
"version": "0.33.4",
"license": "MPL 2.0",
"author": "Murat Doğan, Paul-Louis Ageneau",
"homepage": "https://github.com/murat-dogan/node-datachannel"
},
{
"name": "@node-datachannel/win32-x64-msvc",
"version": "0.33.2",
"version": "0.33.4",
"license": "MPL 2.0",
"author": "Murat Doğan, Paul-Louis Ageneau",
"homepage": "https://github.com/murat-dogan/node-datachannel"
Expand Down Expand Up @@ -309,7 +309,7 @@
},
{
"name": "node-datachannel",
"version": "0.33.2",
"version": "0.33.4",
"license": "MPL 2.0",
"author": "Murat Doğan, Paul-Louis Ageneau",
"homepage": "https://github.com/murat-dogan/node-datachannel#readme"
Expand Down