Skip to content

chore(deps): update dependency @node-datachannel/darwin-x64 to v0.33.4 - #639

Draft
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/node-datachannel-darwin-x64-0.x
Draft

chore(deps): update dependency @node-datachannel/darwin-x64 to v0.33.4#639
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/node-datachannel-darwin-x64-0.x

Conversation

@renovate

@renovate renovate Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@node-datachannel/darwin-x64 0.33.20.33.4 age adoption passing confidence

Release Notes

murat-dogan/node-datachannel (@​node-datachannel/darwin-x64)

v0.33.4

Compare Source

What's Changed

New Contributors

Full Changelog: murat-dogan/node-datachannel@v0.33.1...v0.33.4

v0.33.3

Compare Source


Configuration

📅 Schedule: (in timezone America/Los_Angeles)

  • Branch creation
    • Only on Monday (* * * * 1)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3fb0d5d
Status: ✅  Deploy successful!
Preview URL: https://37d7b6d8.mouseterm.pages.dev
Branch Preview URL: https://renovate-node-datachannel-da-0ano.mouseterm.pages.dev

View logs

@dormouse-bot dormouse-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback on a draft — not a merge verdict. Build & Test is red on this branch and the fix isn't on it, so flagging where it does belong.

Bumping one @node-datachannel/* platform package alone breaks the dependency disclosure gate. docs/specs/security-supply-chain.md -> "An unresolvable dependency throws unless an optional-edge rule covers it" requires a platform package a product root declares to be describable "from a sibling in the same optionalDependencies block at the same exact version string". On Linux CI @node-datachannel/darwin-x64 isn't installed, and after this bump it has no sibling at 0.33.4 — every other entry is still 0.33.2 — so website/scripts/generate-deps.js throws rather than emitting a stale file. That's the Dependency disclosure is current step failing in Build & Test. The sibling PR #637 shows the same error verbatim: "@node-datachannel/darwin-arm64" is not installed and neither is any sibling declared beside it at the same version, so it cannot be described.

This is systemic rather than specific to this PR: #637, #639, and #640 each move one member of the family and each is red for the same reason, so none can go green on its own and merging them one at a time keeps the tree broken in between. renovate.json already groups every other lockstep family here — react, react-router, tailwindcss, storybook, vite, xterm — and @node-datachannel/** needs the same treatment.

The group has to include node-datachannel itself, not just the scope. The core package is a plain dependencies entry still pinned to 0.33.2, and its own manifest re-pins every platform package to 0.33.2 — visible in the lockfile, where node-datachannel@0.33.2's snapshot lists '@node-datachannel/darwin-x64': 0.33.2 and this PR adds a second @node-datachannel/darwin-x64@0.33.4 entry beside it rather than replacing it. Since the addon resolves from its own package directory (docs/specs/standalone.md -> "The direct path": "the addon resolves its .node relative to its own __dirname"), a darwin-x64 machine would likely go on loading 0.33.2 while the 0.33.4 prebuild is copied into the shipped standalone/sidecar/node_modules unused. I haven't run the resolution on a darwin-x64 host to confirm which copy wins, but either way the intended effect of this bump — picking up libdatachannel 0.24.5 and its DTLS handshake fix — doesn't arrive until the core package moves too.

A rule matching node-datachannel and @node-datachannel/** under one groupName, with separateMajorMinor: false, would keep the seven packages in one PR and one version string. Worth noting in its description why: the disclosure generator's same-exact-version sibling rule, not just build convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant