skills(running-tend): mark Chromatic UI Tests check as human-gated in approval poll - #324
Merged
Merged
Conversation
Deploying mouseterm with
|
| Latest commit: |
0309424
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f4910516.mouseterm.pages.dev |
| Branch Preview URL: | https://daily-review-runs-3034995845.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
running-tendrule telling review runs that Chromatic'sUI Testsstatus context is human-gated, so the gated-approval CI poll stops once every automated check is green instead of polling that context to the cap.Why
When
tend-reviewapproves a visually-changing PR, the approval is gated, so it runs the CI Monitoring poll to dismiss-on-red. TheUI Testscontext (Chromatic,target_url→chromatic.com/build...) sitsPENDINGfor the whole poll because Chromatic holds it open until a maintainer accepts or rejects the visual diffs in the Chromatic UI — it never auto-terminalizes in-session. The bot already disposes of this correctly (caps the poll, confirms nothing went red, keeps the approval standing), but it burns ~9–17 job-minutes per visually-changing PR review waiting on a context that can't move.This is a structural pattern (reproduces on every visually-changing PR) and has now been observed three times, which is the action threshold recorded on the monthly tracking issue #199:
UI Tests(Chromatic build #407) stayedPENDING; the bot logged it as "gated rather than in-progress," kept the approval, but polled to the cap first.The rule names only
UI Tests— its sibling Chromatic checkStorybook Publishterminalizes normally and must keep gating — so it won't over-generalize to genuinely-slow required checks. Repo-local rather than an upstream/bundled change because "UI Testsis human-gated" is Chromatic-setup-specific knowledge the generic CI Monitoring recipe can't safely assume for other consumers.Opened by the daily
review-runssweep (run 30349958456).