chore(lib): drop dead MobileTerminalSection type alias - #322
Conversation
Unused across the whole monorepo — a repo-wide search finds only the definition, and nothing re-exports it. Leftover from the Section -> KeyboardMode rename; live code uses MobileTerminalKeyboardMode directly.
Deploying mouseterm with
|
| Latest commit: |
149614b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://823a7299.mouseterm.pages.dev |
| Branch Preview URL: | https://chore-drop-dead-mobile-termi.mouseterm.pages.dev |
|
CI note: every build/test check is green (Build & Test, Standalone Smoketest, Visual Regression, Storybook Publish, UI Tests, review). The one red is Cloudflare Pages, which failed instantly — This is a transient external-deploy hiccup, not something this change could cause: it only deletes an unused TypeScript type, the website build is exercised and passing via the Storybook/UI/Visual-Regression checks, and Cloudflare Pages succeeded on the sibling PRs open right now (#321, #320, #317). Cloudflare is also reporting an active minor incident. The Pages deploy should go green on the next push; re-running it (or merging) needs no code change here. |
2 participants
Removes the dead exported type alias
MobileTerminalSectioninlib/src/components/MobileTerminalUi.tsx.export type MobileTerminalSection = MobileTerminalKeyboardMode;has no references anywhere in the monorepo — a repo-wide search over.ts/.tsxfinds only the definition itself, and no barrel re-exports it. It's a leftover alias from theSection→KeyboardModenaming; the livesectionprops and every other consumer useMobileTerminalKeyboardModedirectly.Scope is limited to deleting the one orphaned alias. The broader question of whether the parallel
activeSection/defaultSection/onSectionChangeprop triple should be collapsed into thekeyboardModetriple is left for a maintainer, since that touches the Storybook stories that exercise it.No test accompanies this change — it's a pure dead-code removal with no runtime behavior;
tsc -bin CI confirms nothing referenced the removed type.