Repository navigation
Correct the Hosted billing specs' stale cross-reference, built Future rules, metrics row, and cron comment - #1435
Merged
Merged
Conversation
pricing.md's cohort rule cited a "Checkout" heading that now holds only unbuilt work, and its Future list restated two rules already built (no trial, a full refund ends the subscription). hosted.md's Metrics table read as if a refunded end also counted as canceled; processEvent counts exactly one. The wrangler cron comment named only one of resyncBilling's passes.
Deploying mouseterm with
|
| Latest commit: |
6dc9d11
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://847a506f.mouseterm.pages.dev |
| Branch Preview URL: | https://docs-hosted-billing-spec-dri.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only: four places in the Hosted billing docs had drifted from the code that landed in #1407–#1426. Specs and lints pass locally (
node scripts/spec-lint.mjs,node scripts/md-unwrap.mjs); no test is added because nothing here changes behavior.docs/specs/pricing.md→ "Checkout and entitlement": the "Cohorts close by count" bullet pointed at("Checkout")for the rule that a full refund or finally reversed payment ends a subscription. That heading is now the## Futuresection holding only Van Westendorp and licensing; the rule itself is two bullets down in the same section. Dropped the pointer.docs/specs/pricing.md→ Future "Renewal, cancellation, refund": removed two rules that are already built and stated above the fold — "No trial" (docs/specs/hosted.md→ "Billing": "Never offer a trial or Managed Payments") and "A full refund revokes" (the "A full refund or a finally reversed payment ends the subscription it paid for" bullet). The remaining Future items are untouched; whether the 30-day guarantee and auto-renew bullets should also move above the fold is left to you.docs/specs/hosted.md→ Metrics: thesubscription.canceledrow read as counting every end, makingsubscription.refundedlook like a subset.processEventcounts exactly one of the two, so the row now says "unless refunded".hosted.md's budget is re-baselined 6300 → 6350 for the two added words.hosted/wrangler.jsonc: the cron comment described only the lapsed-subscription resync;resyncBillingalso settles withdrawals, retries closure refunds, rereads open disputes, sends notices, and applies price changes.