Repository navigation
fix: remove the duplicate dispute-charge route from the hosted Stripe test fake - #1429
Merged
Merged
Conversation
Deploying mouseterm with
|
| Latest commit: |
9a5ad94
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c15c2a7e.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-issue-1428.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1425 and #1426 each added a fake Stripe route for
GET /v1/charges/ch_for_<id>tohosted/server/tests/stripe-fake.ts, and merging both kept the two blocks in the same scope, sohosted'stsc --noEmitfails withTS2451: Cannot redeclare block-scoped variable 'charge'and stopspnpm buildonmain(run 40813938991). This removes the second block and keeps #1426's handler, which callsdisputedCharge. Both handlers returned the same charge body and the same 404 for an unknown dispute, and the first one matched every request, so the second was unreachable. Test behavior does not change.The sandbox could not install dependencies (no registry access), so I couldn't run the typecheck locally. The
Build & Testcheck on this PR is the verification.Closes #1428 — automated triage