Conversation
Moves the vendored miniz sources from jbmc/src/miniz/ to 3p/miniz-3.0.2/, and adds 3p/copyright.miniz-3.0.2 (Debian copyright-format 1.0) documenting provenance (upstream commit 0c30a001bc3c70, Expat license) and the local modifications. The build glue remains in jbmc/src/miniz/. Also removes the stale src/miniz/module_dependencies.txt, left behind when miniz moved to jbmc/src. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9114 +/- ##
===========================================
- Coverage 80.77% 80.77% -0.01%
===========================================
Files 1712 1712
Lines 189814 189814
Branches 73 73
===========================================
- Hits 153328 153322 -6
- Misses 36486 36492 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
peterschrammel
left a comment
Member
There was a problem hiding this comment.
3p is short, but third-party would be more self-explanatory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jbmc/src/miniz/to3p/miniz-3.0.2/3p/copyright.miniz-3.0.2(Debian copyright-format 1.0) documenting provenance (upstream commit0c30a001bc3c70, i.e. release 3.0.2 plus the CVE-2018-12913 fix, Expat/MIT license) and the local modificationsjbmc/src/miniz/; include paths and lint exclusions (.clang-format-ignore, cpplint) now reference3p/src/miniz/module_dependencies.txtleft behind when miniz moved tojbmc/srcTest plan
make -C jbmc/src/minizandmake -C jbmc/src/java_bytecode mz_zip_archive.obuild cleanly with-Werrorminizandjava_bytecodeobjects succeeds🤖 Generated with Claude Code