Skip to content

Move third-party miniz library to 3p/miniz-3.0.2#9114

Open
kroening wants to merge 1 commit into
developfrom
3p-miniz
Open

Move third-party miniz library to 3p/miniz-3.0.2#9114
kroening wants to merge 1 commit into
developfrom
3p-miniz

Conversation

@kroening

Copy link
Copy Markdown
Collaborator

Summary

  • Moves the vendored miniz sources from jbmc/src/miniz/ to 3p/miniz-3.0.2/
  • Adds 3p/copyright.miniz-3.0.2 (Debian copyright-format 1.0) documenting provenance (upstream commit 0c30a001bc3c70, i.e. release 3.0.2 plus the CVE-2018-12913 fix, Expat/MIT license) and the local modifications
  • The build glue remains in jbmc/src/miniz/; include paths and lint exclusions (.clang-format-ignore, cpplint) now reference 3p/
  • Removes the stale src/miniz/module_dependencies.txt left behind when miniz moved to jbmc/src

Test plan

  • make -C jbmc/src/miniz and make -C jbmc/src/java_bytecode mz_zip_archive.o build cleanly with -Werror
  • CMake build of the miniz and java_bytecode objects succeeds
  • Full CI build passes

🤖 Generated with Claude Code

Moves the vendored miniz sources from jbmc/src/miniz/ to 3p/miniz-3.0.2/,
and adds 3p/copyright.miniz-3.0.2 (Debian copyright-format 1.0) documenting
provenance (upstream commit 0c30a001bc3c70, Expat license) and the local
modifications. The build glue remains in jbmc/src/miniz/.

Also removes the stale src/miniz/module_dependencies.txt, left behind when
miniz moved to jbmc/src.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.77%. Comparing base (f5bf9cc) to head (8b39122).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9114      +/-   ##
===========================================
- Coverage    80.77%   80.77%   -0.01%     
===========================================
  Files         1712     1712              
  Lines       189814   189814              
  Branches        73       73              
===========================================
- Hits        153328   153322       -6     
- Misses       36486    36492       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@peterschrammel peterschrammel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3p is short, but third-party would be more self-explanatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants