Skip to content

Do not use as const with Z3 due to soundness issue#9011

Open
tautschnig wants to merge 1 commit into
diffblue:developfrom
tautschnig:z3-workaround
Open

Do not use as const with Z3 due to soundness issue#9011
tautschnig wants to merge 1 commit into
diffblue:developfrom
tautschnig:z3-workaround

Conversation

@tautschnig
Copy link
Copy Markdown
Collaborator

Disable as const for Z3 as it produces wrong results per Z3Prover/z3#9550.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Disable `as const` for Z3 as it produces wrong results per
Z3Prover/z3#9550.
Copilot AI review requested due to automatic review settings May 19, 2026 08:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables the SMT2 as const array constant construct for the Z3 backend due to a soundness bug in Z3 (Z3Prover/z3#9550) that causes incorrect results.

Changes:

  • Set use_as_const = false for the Z3 solver path in smt2_convt's constructor.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.55%. Comparing base (82ba0cc) to head (e9816ba).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9011      +/-   ##
===========================================
- Coverage    80.55%   80.55%   -0.01%     
===========================================
  Files         1707     1707              
  Lines       189047   189047              
  Branches        73       73              
===========================================
- Hits        152292   152287       -5     
- Misses       36755    36760       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants