Repository navigation
feat!: add support for pnpm and drop cli-style dependencies - #11
Merged
Merged
Conversation
kabaros
changed the title
KaiVandivier
approved these changes
Sep 21, 2026
KaiVandivier
left a comment
KaiVandivier
left a comment
There was a problem hiding this comment.
Looks good! Got one suggestion --
| - run: echo "${{ github.event.pull_request.title }}" | npx commitlint --config ${{ steps.commitlint.outputs.CONFIG_PATH }} | ||
| cache: pnpm | ||
| - run: pnpm install --frozen-lockfile | ||
| - run: echo "${{ github.event.pull_request.title }}" | pnpx commitlint@12 --config commitlint.config.mjs |
There was a problem hiding this comment.
Tip from ClaudeAI: a PR title containing something like "; curl … # would run as a command here -- the usual fix is to pass the title through an environment variable:
- run: echo "$PR_TITLE" | pnpx commitlint@12 --config commitlint.config.mjs
env:
PR_TITLE: ${{ github.event.pull_request.title }}
…title
Based on the pnpm branch. lint.yml now runs the consuming app's own `pnpm
lint` script instead of `pnpm d2-style check`, and lint-commits.yml /
lint-pr-title.yml point commitlint straight at the app's own
commitlint.config.mjs instead of resolving the config via
require('@dhis2/cli-style').config.commitlint -- which breaks for any app
that has migrated off cli-style onto the shared @dhis2/config-* packages.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
kabaros
force-pushed
the
pnpm-no-cli-style
branch
from
September 21, 2026 13:25
bb9ade4 to
3d8878a
Compare
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains:
pnpmbranch to support workflows with pnpmpnpm-no-cli-stylewhich drops the dependency of the workflows on@dhi2/cli-styleBREAKING CHANGE: The previous v1 version works with
yarn 1. Apps have to be bumped to use pnpm and drop cli-style before using this branch. These changes can be automated using the modernise-apps skill