test: align GraphQL health check retries with gRPC pattern#9752
Open
matthewmcneely wants to merge 1 commit into
Open
test: align GraphQL health check retries with gRPC pattern#9752matthewmcneely wants to merge 1 commit into
matthewmcneely wants to merge 1 commit into
Conversation
The waitUntilGraphqlHealthCheck function had a retry mismatch: it only retried login 5 times before failing, while waitUntilGrpcHealthCheck retries 10 times. This asymmetry caused flaky failures in TestNamespaceAwareRestoreOnMultipleGroups when the server wasn't fully ready within the 5-second window. Changes: - Increase GraphQL login retry attempts from 5 to 10 (matching gRPC pattern) - Add warning logs for failed attempts after attempt 5 for visibility - Add logging to the DeleteUser health check loop for consistency This gives the cluster more time to become ready without extending the total wait period beyond what gRPC health checks already do. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
waitUntilGraphqlHealthCheckfunction had a retry mismatch: it only retried login 5 times before failing, whilewaitUntilGrpcHealthCheckretries 10 times. This asymmetry caused flaky failures inTestNamespaceAwareRestoreOnMultipleGroups(and others) when the server wasn't fully ready within the 5-second window.Changes:
This gives the cluster more time to become ready without extending the total wait period beyond what gRPC health checks already do.
Checklist
Conventional Commits syntax, leading
with
fix:,feat:,chore:,ci:, etc.