fix: S390x compatability#9746
Open
navaneeswar1011 wants to merge 4 commits into
Open
Conversation
matthewmcneely
requested changes
Jun 17, 2026
e998709 to
2e7fbf6
Compare
matthewmcneely
requested changes
Jun 18, 2026
Contributor
There was a problem hiding this comment.
These changes are out of scope. Please revert. I will address in another PR
2e7fbf6 to
05122ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a build failure encountered while compiling Dgraph on IBM s390x architecture caused by a datatype mismatch in the disk metrics module.
Problem
During compilation, the build fails in
x/disk_metrics_linux.godue to architecture-specific type differences in the Linuxsyscall.Statfs_tstructure.The existing implementation performs arithmetic operations using mixed types:
On s390x architecture, the datatype definitions for
Frsize,Blocks, andBavaildiffer from architectures such asx86_64, causing a compile-time type mismatch.Fix
Added explicit type conversion for
Frsizeto ensure consistent datatype handling during arithmetic operations.Updated code:
Validation Performed
The fix was validated by building and testing on multiple architectures:
Additionally verified:
Impact
Checklist
Conventional Commits syntax, leading
with
fix:,feat:,chore:,ci:, etc.