fixed path separator handling in test for windows compatibility#116
Closed
csoltenborn wants to merge 1 commit intodflib:mainfrom
Closed
fixed path separator handling in test for windows compatibility#116csoltenborn wants to merge 1 commit intodflib:mainfrom
csoltenborn wants to merge 1 commit intodflib:mainfrom
Conversation
Contributor
|
Hi @csoltenborn . Thanks for bringing this to our attention. Kinda dropped the ball on the original PR. Anyways, I rebased #98 and created a new PR #117. It no longer has CI/CD issues so I was able to merge it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically a duplicate of #98, but only fixes the path issue... locally, I can run the tests without further adjustments, maybe because of 31f1e97 (Testcontainers 2.0).