ci(release): allowlist the files the release bot may change - #665
Open
MRmarioruci wants to merge 1 commit into
Open
MRmarioruci wants to merge 1 commit into
MRmarioruci wants to merge 1 commit into
Conversation
The Cut release workflow opens its PR as github-actions, which makes the Check Bot Policies job run instead of skip. That job reads .github/repo_policies/BOT_APPROVED_FILES from the default branch and throws when it is absent, so every bot-authored release PR is blocked on a check that can never pass. Patterns cover the version and changelog files release prepare writes for each project, plus .release.json, Cargo.lock, the wallet compat file and the test crates whose dependency versions bump with the released crates. Verified against every file in the last 12 release commits. .github/** is deliberately excluded, so a bot PR cannot change a workflow, an action, or this allowlist.
|
✅ No security or compliance issues detected. Reviewed everything up to 2b6fda2. Security Overview
Detected Code Changes
|
sea-snake
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every release PR is blocked on a check that cannot pass. #663 is the first one to hit it.
The Cut release workflow opens its PR as
github-actions, soCheck Bot Policiesruns instead of skipping. That job reads.github/repo_policies/BOT_APPROVED_FILESfrom the default branch and raises when the file is missing, which is the 404 traceback on #663. Human-opened PRs skip the job entirely, which is why nothing before #663 saw it.This adds the file. The patterns cover the version and changelog
release preparewrites per project, plus.release.json,Cargo.lock, the wallet'scompat.json, and the test crates whose dependency versions bump alongside released crates..github/**is excluded on purpose, so a bot PR cannot change a workflow, an action, or this allowlist.Verified with
fnmatchagainst the union of every file changed by the last 12 release commits plus #663, 30 distinct paths, all covered. Also checked that.github/workflows/release.yaml,scripts/deploy-app,cli/src/cli.ts,canister_ids.json,dfx.jsonand station source are all still blocked.The job reads the config from the default branch, so #663 needs no rebase. Merge this, then re-run its failed check.