fix(orchestrator): mock starting processes in upgrade unit tests#9528
Merged
pierugo-dfinity merged 14 commits intomasterfrom Mar 24, 2026
Merged
Conversation
…tests (#9521) This PR deflakes `//rs/orchestrator:orchestrator_test` by mocking the process management of the orchestrator such that no process is actually spawned when the upgrade loop supposedly starts the replica. To do so, this moves the struct `ProcessManager` to a trait that exposes the public functions and leaves the implementation to `ProcessManagerImpl`. Now, a `FakeProcessManager` can be used, whose implementation is keeping track of a boolean mocking whether the process is running or not. This was mostly AI-generated, supervised and reviewed by me.
Contributor
Author
|
Now that the location of |
kpop-dfinity
approved these changes
Mar 24, 2026
pierugo-dfinity
deleted the
pierugo/orchestrator/mock-replica-and-manageboot
branch
alin-at-dfinity
pushed a commit
that referenced
this pull request
Mar 26, 2026
This PR extends #9521 to also mock the execution of `manageboot.sh` in an effort to deflake `//rs/orchestrator:orchestrator_test`. Similarly, we replace all call sites with a trait function that is implemented differently based on an argument of the `Upgrade` struct. The PR also turns relevant `String`/`&str` to `OsString`/`&OsStr` when they are used in places expecting an `AsRef<OsStr>` to avoid awkward casts like `PathBuf.as_path().display().to_string()` (and to make more sense conceptually).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends #9521 to also mock the execution of
manageboot.shin an effort to deflake//rs/orchestrator:orchestrator_test. Similarly, we replace all call sites with a trait function that is implemented differently based on an argument of theUpgradestruct.The PR also turns relevant
String/&strtoOsString/&OsStrwhen they are used in places expecting anAsRef<OsStr>to avoid awkward casts likePathBuf.as_path().display().to_string()(and to make more sense conceptually).