Skip to content

feat(ic-management-canister-types): add canister snapshot visibility settings#9509

Merged
gregorydemay merged 3 commits intomasterfrom
gdemay/DEFI-2667-snapshot-visibility-settings-types
Apr 14, 2026
Merged

feat(ic-management-canister-types): add canister snapshot visibility settings#9509
gregorydemay merged 3 commits intomasterfrom
gdemay/DEFI-2667-snapshot-visibility-settings-types

Conversation

@gregorydemay
Copy link
Copy Markdown
Contributor

Summary

@github-actions github-actions bot added the feat label Mar 20, 2026
@gregorydemay gregorydemay marked this pull request as ready for review March 20, 2026 08:07
@gregorydemay gregorydemay requested a review from a team as a code owner March 20, 2026 08:07
@gregorydemay gregorydemay requested a review from mraszyk March 20, 2026 08:08
Copy link
Copy Markdown
Contributor

@mraszyk mraszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the changelog?

Otherwise LGTM but we should merge this only when the feature is rolled out in production so not approving yet,

gregorydemay and others added 2 commits April 14, 2026 08:51
Add unreleased changelog entry for the new `snapshot_visibility` field
and `SnapshotVisibility` type.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@gregorydemay
Copy link
Copy Markdown
Contributor Author

@mraszyk : sorry for the delay.

Could you please update the changelog?

Added in 0c5c49b.

Otherwise LGTM but we should merge this only when the feature is rolled out in production so not approving yet,

Now would be ok to merge, no?

@gregorydemay gregorydemay requested a review from mraszyk April 14, 2026 09:01
@gregorydemay gregorydemay added this pull request to the merge queue Apr 14, 2026
Merged via the queue into master with commit 9f7f945 Apr 14, 2026
39 checks passed
@gregorydemay gregorydemay deleted the gdemay/DEFI-2667-snapshot-visibility-settings-types branch April 14, 2026 10:25
daniel-wong-dfinity-org pushed a commit that referenced this pull request Apr 15, 2026
…settings (#9509)

## Summary
- Add new canister snapshot visibility settings as specified in
dfinity/portal#6195.

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants