refactor(node): reorganize rs/ic_os#8194
Conversation
There was a problem hiding this comment.
This pull request modifies the IC-OS configuration types library (rs/ic_os/config_types/src/lib.rs).
Please ensure you have followed the Configuration Update Protocol guidelines——particularly if adding a new enum or enum variants:
Enum Variant Forward Compatibility Guidelines: If adding a new enum or new variants to an enum, ensure older versions can handle unknown variants gracefully by using #[serde(other)] on a fallback variant. See examples: GuestVMType::Unknown and Ipv6Config::Unknown.
To acknowledge this reminder and unblock the PR, dismiss this code review by:
- Going to the bottom of the pull request page
- Finding where this bot is requesting changes
- Clicking the three dots on the right
- Selecting "Dismiss review"
For complete guidelines, see the documentation at the top of rs/ic_os/config_types/src/lib.rs.
CONFIG_TYPES_COMPATIBILITY_REMINDER_DEDUP
|
I want to follow up on this with another reorganization, but this is enough for now! |
Strictly a refactor
This reverts commit 9805588.
NODE-1738