feat: [DSM-148] XNetClient::post_advert() - #11613
Open
alin-at-dfinity wants to merge 1 commit into
Open
alin-at-dfinity wants to merge 1 commit into
alin-at-dfinity wants to merge 1 commit into
Conversation
POSTs a header-only certified slice — our stream to the peer — and returns the peer's own certified header if it replied with one, i.e. if the advert brought it nothing new. A 204 is the ordinary outcome and not an error, unlike for `query()`, where it means there is no stream. An advert above `ADVERT_MAX_BODY_BYTES` is refused before it is sent, as the receiver would refuse it too and the fault is ours. Being refused by the peer (429, 403) leaves it healthy, as 4xx already does for `query()`; only the failures that say the node did not serve us mark it unhealthy. Nothing sends adverts yet; the task that does, and that feeds a reply back through `handle_advert()`, follows. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
✅ No security or compliance issues detected. Reviewed everything up to 403ca7e. Security OverviewDetected Code Changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POSTs a header-only certified slice — our stream to the peer — and returns the peer's own certified header if it replied with one, i.e. if the advert brought it nothing new. A 204 is the ordinary outcome and not an error, unlike for
query(), where it means there is no stream.An advert above
ADVERT_MAX_BODY_BYTESfails before being sent, as the receiver would refuse it and the fault is ours. Being refused by the peer (429, 403) leaves it healthy, as 4xx already does forquery(); only the failures that say the node did not serve us mark it unhealthy.Nothing sends adverts yet; the task that does, and that feeds a reply back through
handle_advert(), follows.