Conversation
This goes through a few crates and disables a few unused features, clearing up the dependency graph. Additionally the `crossbeam` crate is replaced with `crossbeam-utils` (smaller but exports everything we need) and `json-patch` is removed and the single function used is inlined.
|
✅ No security or compliance issues detected. Reviewed everything up to 1b0dc24. Security Overview
Detected Code Changes
|
|
✅ No security or compliance issues detected. Reviewed everything up to 1b0dc24. Security Overview
Detected Code Changes
|
basvandijk
approved these changes
Sep 11, 2026
schneiderstefan
approved these changes
Sep 11, 2026
nmattia
enabled auto-merge
September 11, 2026 12:40
Resolves a merge conflict in Cargo.Bazel.json.lock (the auto-generated crate_universe lockfile): both branches independently changed Cargo.toml/bazel/rust.MODULE.bazel (this branch removes crates for unused features; master bumps wasmtime and other deps), and every crate entry auto-merged cleanly except the file's single self-referential "checksum" field, where both sides had recomputed a different value for their own state. That field only feeds crate_universe's staleness check (it plays no role in dependency resolution); its value here is a placeholder from the master side pending a real repin. `cargo metadata --locked` succeeds against the merged Cargo.lock/Cargo.toml, confirming the Cargo-side dependency graph is fully self-consistent. Note for reviewers/CI: this sandbox could not run `./bin/bazel-pin.sh` to regenerate the authoritative checksum in Cargo.Bazel.json.lock -- Bazel's bzlmod module resolution for this workspace needs dozens of transitive external repos fetched over `codeload.github.com` and other hosts that this session's outbound network policy blocks (only DFINITY's internal Bazel remote cache/downloader and releases.bazel.build were reachable via a GCS mirror; the wider dependency graph was not). Please run `./bin/bazel-pin.sh --force` in an environment with full network access before merging to refresh that checksum. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016kWotpWN6DJC8SWj5qriBK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This goes through a few crates and disables a few unused features, clearing up the dependency graph. Additionally the
crossbeamcrate is replaced withcrossbeam-utils(smaller but exports everything we need) andjson-patchis removed and the single function used is inlined.