Skip to content

feat: disable unused features - #11544

Open
nmattia wants to merge 3 commits into
masterfrom
nm-disable-unused-features
Open

nmattia wants to merge 3 commits into
masterfrom
nm-disable-unused-features

Conversation

@nmattia

@nmattia nmattia commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

This goes through a few crates and disables a few unused features, clearing up the dependency graph. Additionally the crossbeam crate is replaced with crossbeam-utils (smaller but exports everything we need) and json-patch is removed and the single function used is inlined.

This goes through a few crates and disables a few unused features,
clearing up the dependency graph. Additionally the `crossbeam` crate is
replaced with `crossbeam-utils` (smaller but exports everything we need)
and `json-patch` is removed and the single function used is inlined.
@nmattia
nmattia requested review from a team as code owners September 11, 2026 11:45
@github-actions github-actions Bot added the feat label Sep 11, 2026
github-actions[bot]

This comment was marked as spam.

@zeropath-ai

zeropath-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 1b0dc24.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► rs/http_endpoints/public/src/health_status_refresher.rs
    Replace crossbeam::atomic::AtomicCell with crossbeam_utils::atomic::AtomicCell
Enhancement ► rs/http_endpoints/public/src/lib.rs
    Replace crossbeam::atomic::AtomicCell with crossbeam_utils::atomic::AtomicCell
Enhancement ► rs/http_endpoints/public/src/query.rs
    Replace crossbeam::atomic::AtomicCell with crossbeam_utils::atomic::AtomicCell
Enhancement ► rs/http_endpoints/public/src/read_state.rs
    Replace crossbeam::atomic::AtomicCell with crossbeam_utils::atomic::AtomicCell
Enhancement ► rs/http_endpoints/public/src/status.rs
    Replace crossbeam::atomic::AtomicCell with crossbeam_utils::atomic::AtomicCell
Enhancement ► rs/http_endpoints/public/Cargo.toml
    Use crossbeam-utils = workspace dependency instead of crossbeam
Enhancement ► rs/http_endpoints/public/BUILD.bazel
    Replace crossbeam with crossbeam-utils in dependencies for rust tests and libs
Enhancement ► rs/sns/cli/BUILD.bazel
    Remove json-patch from dependencies in BUILD targets
Enhancement ► rs/sns/cli/Cargo.toml
    Remove json-patch dependency
Enhancement ► rs/sns/cli/src/deploy.rs
    Replace json_patch::merge with json_merge_patch function
Enhancement ► rs/sns/cli/src/deploy.rs
    Add json_merge_patch function implementing RFC 7396 JSON Merge Patch

@zeropath-ai

zeropath-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 1b0dc24.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► rs/http_endpoints/public/src/health_status_refresher.rs
    Replace crossbeam::atomic::AtomicCell with crossbeam_utils::atomic::AtomicCell
Enhancement ► rs/http_endpoints/public/src/lib.rs
    Replace crossbeam::atomic::AtomicCell with crossbeam_utils::atomic::AtomicCell
Enhancement ► rs/http_endpoints/public/src/query.rs
    Replace crossbeam::atomic::AtomicCell with crossbeam_utils::atomic::AtomicCell
Enhancement ► rs/http_endpoints/public/src/read_state.rs
    Replace crossbeam::atomic::AtomicCell with crossbeam_utils::atomic::AtomicCell
Enhancement ► rs/http_endpoints/public/src/status.rs
    Replace crossbeam::atomic::AtomicCell with crossbeam_utils::atomic::AtomicCell
Enhancement ► rs/http_endpoints/public/Cargo.toml
    Use crossbeam-utils = workspace dependency instead of crossbeam
Enhancement ► rs/http_endpoints/public/BUILD.bazel
    Replace crossbeam with crossbeam-utils in dependencies for rust tests and libs
Enhancement ► rs/sns/cli/BUILD.bazel
    Remove json-patch from dependencies in BUILD targets
Enhancement ► rs/sns/cli/Cargo.toml
    Remove json-patch dependency
Enhancement ► rs/sns/cli/src/deploy.rs
    Replace json_patch::merge with json_merge_patch function
Enhancement ► rs/sns/cli/src/deploy.rs
    Add json_merge_patch function implementing RFC 7396 JSON Merge Patch

@nmattia
nmattia enabled auto-merge September 11, 2026 12:40
Resolves a merge conflict in Cargo.Bazel.json.lock (the auto-generated
crate_universe lockfile): both branches independently changed
Cargo.toml/bazel/rust.MODULE.bazel (this branch removes crates for
unused features; master bumps wasmtime and other deps), and every
crate entry auto-merged cleanly except the file's single self-referential
"checksum" field, where both sides had recomputed a different value for
their own state. That field only feeds crate_universe's staleness check
(it plays no role in dependency resolution); its value here is a
placeholder from the master side pending a real repin.

`cargo metadata --locked` succeeds against the merged Cargo.lock/Cargo.toml,
confirming the Cargo-side dependency graph is fully self-consistent.

Note for reviewers/CI: this sandbox could not run `./bin/bazel-pin.sh` to
regenerate the authoritative checksum in Cargo.Bazel.json.lock -- Bazel's
bzlmod module resolution for this workspace needs dozens of transitive
external repos fetched over `codeload.github.com` and other hosts that
this session's outbound network policy blocks (only DFINITY's internal
Bazel remote cache/downloader and releases.bazel.build were reachable via
a GCS mirror; the wider dependency graph was not). Please run
`./bin/bazel-pin.sh --force` in an environment with full network access
before merging to refresh that checksum.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016kWotpWN6DJC8SWj5qriBK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants