Skip to content

feat: migrate non-governance canisters to new ic_cdk call interface - #10995

Merged
nmattia merged 2 commits into
masterfrom
nm-ic-cdk-call
Aug 4, 2026
Merged

feat: migrate non-governance canisters to new ic_cdk call interface#10995
nmattia merged 2 commits into
masterfrom
nm-ic-cdk-call

Conversation

@nmattia

@nmattia nmattia commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

This migrates most canisters outside of the production NNS/governance canisters to the new ic-cdk cross-canister call interface introduced in 0.18. This tries to keep the old behavior wherever possible.

This migrates most canisters outside of the production NNS/governance
canisters to the new ic-cdk cross-canister call interface introduced in
0.18. This tries to keep the old behavior wherever possible.
@github-actions github-actions Bot added the feat label Aug 3, 2026
@nmattia
nmattia marked this pull request as ready for review August 3, 2026 13:00
@nmattia
nmattia requested review from a team as code owners August 3, 2026 13:00
github-actions[bot]

This comment was marked as spam.

@zeropath-ai

zeropath-ai Bot commented Aug 3, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 35b1066.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► packages/icrc-ledger-client-cdk/src/lib.rs
    Implement CdkRuntime error mapping and use Call::unbounded_wait for IC calls
► packages/pocket-ic/test_canister/src/canister.rs
    Switch from deprecated ic_cdk::call to Call::unbounded_wait for various canister interactions
► rs/boundary_node/salt_sharing/canister/helpers.rs
    Migrate salt regeneration and registry polling to Call-based calls
► rs/nervous_system/timer_task/tests/test_canisters/timer_task_canister.rs
    Update self-call invocation to Call::unbounded_wait
► rs/nns/integration_tests/test_canisters/canister_playground_canister.rs
    Commented example updated to Call::unbounded_wait variant
► rs/tests/test_canisters/message/src/main.rs
    Update forward path to use Call::unbounded_wait with raw args and cycles

@zeropath-ai

zeropath-ai Bot commented Aug 3, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 35b1066.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► packages/icrc-ledger-client-cdk/src/lib.rs
    Implement CdkRuntime error mapping and use Call::unbounded_wait for IC calls
► packages/pocket-ic/test_canister/src/canister.rs
    Switch from deprecated ic_cdk::call to Call::unbounded_wait for various canister interactions
► rs/boundary_node/salt_sharing/canister/helpers.rs
    Migrate salt regeneration and registry polling to Call-based calls
► rs/nervous_system/timer_task/tests/test_canisters/timer_task_canister.rs
    Update self-call invocation to Call::unbounded_wait
► rs/nns/integration_tests/test_canisters/canister_playground_canister.rs
    Commented example updated to Call::unbounded_wait variant
► rs/tests/test_canisters/message/src/main.rs
    Update forward path to use Call::unbounded_wait with raw args and cycles

@zeropath-ai

zeropath-ai Bot commented Aug 3, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 35b1066.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► packages/icrc-ledger-client-cdk/src/lib.rs
    Implement CdkRuntime error mapping and use Call::unbounded_wait for IC calls
► packages/pocket-ic/test_canister/src/canister.rs
    Switch from deprecated ic_cdk::call to Call::unbounded_wait for various canister interactions
► rs/boundary_node/salt_sharing/canister/helpers.rs
    Migrate salt regeneration and registry polling to Call-based calls
► rs/nervous_system/timer_task/tests/test_canisters/timer_task_canister.rs
    Update self-call invocation to Call::unbounded_wait
► rs/nns/integration_tests/test_canisters/canister_playground_canister.rs
    Commented example updated to Call::unbounded_wait variant
► rs/tests/test_canisters/message/src/main.rs
    Update forward path to use Call::unbounded_wait with raw args and cycles

@mbjorkqvist mbjorkqvist left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nmattia!

@nmattia
nmattia enabled auto-merge August 4, 2026 08:41
@nmattia
nmattia added this pull request to the merge queue Aug 4, 2026
Merged via the queue into master with commit b3a371e Aug 4, 2026
45 of 48 checks passed
@nmattia
nmattia deleted the nm-ic-cdk-call branch August 4, 2026 09:37
pull Bot pushed a commit to bit-cook/ic that referenced this pull request Aug 4, 2026
dfinity#10995 caused the error messages
returned by the IC to change slightly, and some `long_test`s (which do
not run on PRs) started failing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants