feat: migrate non-governance canisters to new ic_cdk call interface - #10995
Merged
Conversation
This migrates most canisters outside of the production NNS/governance canisters to the new ic-cdk cross-canister call interface introduced in 0.18. This tries to keep the old behavior wherever possible.
|
✅ No security or compliance issues detected. Reviewed everything up to 35b1066. Security Overview
Detected Code Changes
|
|
✅ No security or compliance issues detected. Reviewed everything up to 35b1066. Security Overview
Detected Code Changes
|
|
✅ No security or compliance issues detected. Reviewed everything up to 35b1066. Security Overview
Detected Code Changes
|
basvandijk
approved these changes
Aug 3, 2026
schneiderstefan
approved these changes
Aug 3, 2026
daniel-wong-dfinity-org-twin
approved these changes
Aug 3, 2026
nmattia
enabled auto-merge
August 4, 2026 08:41
blind-oracle
approved these changes
Aug 4, 2026
pull Bot
pushed a commit
to bit-cook/ic
that referenced
this pull request
Aug 4, 2026
dfinity#10995 caused the error messages returned by the IC to change slightly, and some `long_test`s (which do not run on PRs) started failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates most canisters outside of the production NNS/governance canisters to the new ic-cdk cross-canister call interface introduced in 0.18. This tries to keep the old behavior wherever possible.