Skip to content

chore: remove unnecessary requires-network for guest_upgrade_tests#10895

Merged
basvandijk merged 1 commit into
masterfrom
basvandijk/guest_upgrade_tests-rm-requires-network
Jul 24, 2026
Merged

chore: remove unnecessary requires-network for guest_upgrade_tests#10895
basvandijk merged 1 commit into
masterfrom
basvandijk/guest_upgrade_tests-rm-requires-network

Conversation

@basvandijk

@basvandijk basvandijk commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

The guest_upgrade_tests only requires an internal network so there's no need for external network connectivity.

@github-actions github-actions Bot added the chore label Jul 24, 2026
@basvandijk
basvandijk marked this pull request as ready for review July 24, 2026 10:54
@basvandijk
basvandijk requested a review from a team as a code owner July 24, 2026 10:54
@github-actions github-actions Bot added the @node label Jul 24, 2026
@zeropath-ai

zeropath-ai Bot commented Jul 24, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to db2cbb2.

Security Overview
Detected Code Changes
Change Type Relevant files
Bug Fix ► rs/ic_os/guest_upgrade/tests/BUILD.bazel
    Remove requires-network tag from test configuration

@basvandijk
basvandijk added this pull request to the merge queue Jul 24, 2026
Merged via the queue into master with commit 00054df Jul 24, 2026
69 of 70 checks passed
@basvandijk
basvandijk deleted the basvandijk/guest_upgrade_tests-rm-requires-network branch July 24, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants