chore: finalize motoko/flying_ninja migration to icp-cli#1374
Draft
marc0olo wants to merge 7 commits into
Draft
Conversation
Upgrades icp.yaml to motoko@v5.0.0 and asset-canister@v2.2.1, updates mops.toml toolchain to moc 1.9.0 / core 2.5.0 with correct args format, removes dfx fallbacks from vite.config.js and actor.js, adds Makefile with tests for all public functions, adds CI workflow, rewrites README, and deletes dfx.json, BUILD.md, and .devcontainer/. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Bump @dfinity/asset-canister v2.1.0 → v2.2.1 - Bump ic-cdk 0.16 → 0.20, candid 0.10.10 → 0.10 - Add Makefile with 4 tests - Delete dfx.json, BUILD.md - Bump both container images to icp-dev-env 0.3.2 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ll for raw_rand ic_cdk::api::management_canister was removed in ic-cdk 0.17+. Use ic_cdk::call(Principal::management_canister(), "raw_rand", ()) instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ic_cdk::management_canister was removed — the canonical approach is the dedicated ic-cdk-management-canister = "0.1.1" crate. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finalizes the icp-cli migration for
motoko/flying_ninjaandrust/flying_ninja(both previously had dual dfx/icp support).Motoko:
@dfinity/motoko@v4.1.0→v5.0.0+@dfinity/asset-canister@v2.1.0→v2.2.1; move backend config tomops.toml [canisters.backend]mops.toml: moc 1.9.0, core 2.5.0,--default-persistent-actors; remove redundantpersistentkeyword; fix-Wflag formatvite.config.jsandactor.js; keep icp-cli path onlyMakefilewith tests; deletedfx.json,BUILD.md,.devcontainer/Rust:
@dfinity/rust@v3.2.0+@dfinity/asset-canister@v2.1.0→v2.2.1Makefilewith 4 tests (is_high_score, add_leaderboard_entry, get_leaderboard, get_randomness); deletedfx.json,BUILD.mdbackend/backend.didcommitted (required for frontend bindings)CI: New
flying_ninja.ymlworkflow; both jobs onicp-dev-env-{motoko,rust}:0.3.2Test plan
motoko-flying_ninjaCI passesrust-flying_ninjaCI passes🤖 Generated with Claude Code