chore(vetkeys): migrate basic_vetkd to icp-cli and @icp-sdk/vetkeys#1358
Open
marc0olo wants to merge 4 commits into
Open
chore(vetkeys): migrate basic_vetkd to icp-cli and @icp-sdk/vetkeys#1358marc0olo wants to merge 4 commits into
marc0olo wants to merge 4 commits into
Conversation
Moves motoko/vetkd and rust/vetkd to motoko/vetkeys/basic_vetkd and rust/vetkeys/basic_vetkd, grouping them with the other vetkeys examples. - Replace dfx/webpack with icp-cli + Vite - Switch ic_cdk::management_canister to ic-cdk-management-canister crate - Return blobs instead of hex strings for direct @icp-sdk/vetkeys compat - Use @dfinity/asset-canister@v2.2.1 and icp-dev-env 0.3.1 containers - Add Makefile test target that validates both VetKD endpoints - Remove Hex utility module (no longer needed with blob returns) - Delete old motoko-vetkd-example.yml and rust-vetkd-example.yml workflows - Add unified vetkeys-basic-vetkd.yml CI workflow Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…e prompt in CI Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
motoko/vetkdandrust/vetkdintomotoko/vetkeys/basic_vetkdandrust/vetkeys/basic_vetkd, grouping them alongsidebasic_ibe,basic_bls_signing, etc.make testtarget that CI exercises after deployChanges
Backends:
ic_cdk::management_canistertoic-cdk-management-canister = "0.1.1"crate (Rust)blobinstead of hex-encodedtext— direct compatibility with@icp-sdk/vetkeysHex.moutility (no longer needed)moc 1.9.0/core 2.5.0@dfinity/motoko@v5.0.0(noconfiguration.nameneeded)Frontend:
icpBindgenplugin@dfinity/vetkeys→@icp-sdk/vetkeys ^0.5.0-beta.0@dfinity/auth-client→@icp-sdk/auth ^7.1.0@dfinity/asset-canister@v2.2.1CI:
motoko-vetkd-example.ymlandrust-vetkd-example.yml(dfx-based, failing)vetkeys-basic-vetkd.ymlwithicp-dev-env-{motoko,rust}:0.3.1containersTest plan
make testpassesmake testpasses🤖 Generated with Claude Code