Repository navigation
Conversation
Document the new args_hash field of code_deployment canister history entries introduced by dfinity/ic#12077.
github-actions
Bot
added
the
interface-spec
|
🤖 Here's your preview: https://4aj73-iyaaa-aaaam-aha2q-cai.icp0.io |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The upstream PR dfinity/ic#12077 remains unmerged, and a maintainer must verify rollout to all subnets and replace the placeholder changelog date before publication.
No open issues 🎉
What changed in this PR
This PR updates the Candid interface and ICP reference documentation to describe install-argument hashes in canister deployment history, corresponding to dfinity/ic#12077.
Changes:
- Adds optional
args_hashto code deployment records. - Updates the formal model and reference prose to describe SHA-256 argument hashing and
nullvalues for older entries. - Adds changelog entry 0.71.0 with a rollout-date placeholder explicitly pending verification.
| File | Description |
|---|---|
public/references/ic.did |
Adds args_hash : opt blob to code_deployment. |
docs/references/management-canister.md |
Describes deployment history fields returned by canister_info. |
docs/references/ic-interface-spec/management-canister.md |
Defines argument-hash semantics and compatibility with older entries. |
docs/references/ic-interface-spec/changelog.md |
Records the addition in version 0.71.0. |
docs/references/ic-interface-spec/abstract-behavior.md |
Models argument hashes for install, reinstall, and upgrade history entries. |
Review effort: Balanced
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The linked implementation PR dfinity/ic#12077 remains unmerged, so a maintainer must confirm rollout to all subnets and finalize the changelog date before publication.
No open issues 🎉
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents dfinity/ic#12077, which adds the SHA-256 hash of the
install_codeargument tocode_deploymententries in the canister history.public/references/ic.did: new fieldargs_hash : opt blobincode_deployment.canister_info): a code deployment is also described by the hash of the argument passed tocanister_initorcanister_post_upgrade;nullfor entries recorded before the field existed.CodeDeploymentgainsargs_hash : opt Blob; install/reinstall and upgrade recordopt SHA-256(A.arg).install_chunked_codeis covered because it is rewritten toinstall_code.Before merging: the changelog date is a placeholder (
2026-11-XX, with aNeeds human verificationcomment). dfinity/ic#12077 is not merged yet; the entry should be dated by the day the change reaches all subnets.didc check public/references/ic.didpasses.npm run buildwas not run locally (Node 18 on this machine; Astro needs >= 22.12), so CI is the first build check.