fix: smoke test compile error, run smoke after release - #109
Merged
Conversation
decompressContextAdvanced() still passed a raw int where ZstdDecompressContext.decompress() now requires a ZstdByteSize (the v0.12 domain-primitive refactor), breaking every release-smoke leg. Also trigger release-smoke.yml automatically once publish.yml completes, instead of relying solely on the weekly schedule, so a broken release is caught right after it ships. Fixes #107 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decompressContextAdvanced()in.github/smoke/src/test/java/SmokeTest.javastill passed a rawintwhereZstdDecompressContext.decompress()now requires aZstdByteSize— a leftover from the v0.12 domain-primitive refactor that broke compilation on everyrelease-smoke.ymlleg.release-smoke.ymlnow also triggers on completion ofpublish.yml(in addition to the existing weekly schedule and manual dispatch), so a broken release is caught right after it ships rather than up to a week later.Test plan
.github/smokeagainst the published v0.12 artifact locally (sh .github/smoke/mvnw -f .github/smoke/pom.xml -Dzstd.version=0.12 -Dzstd.classifier=osx-aarch64 test) — 16/16 tests pass.actionlint .github/workflows/release-smoke.yml— no issues.Fixes #107
🤖 Generated with Claude Code