Repository navigation
Closed
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed
Description
The Vector API implementation (VectorApiSimdOperations, PR #524, issue #516) is opt-in at run time, so two configurations ship: with and without --add-modules jdk.incubator.vector. While the module is disabled in the test JVMs (see below), nothing in CI exercises the Vector API kernels: VectorApiSimdOperationsTest skips all 131 of its tests.
Today
- The root
pom.xmlsurefireargLineand theintegrationfailsafeargLineno longer add the module (commitd1be0554on SIMD kernels in one place, plus an opt-in Vector API implementation (#516) #524, disabled "for now"). corehas a second surefire execution (without-vector-module) that now repeats the SIMD tests under the same conditions.
Design: copy Hardwood
Hardwood tests both configurations with one property:
- The root
pom.xmldefinestest.argLine(--enable-native-access=ALL-UNNAMED --add-modules jdk.incubator.vector), and surefire and failsafe both use${test.argLine}. .github/workflows/pr-build.ymlruns the integration tests twice: once with-Dtest.argLine="--enable-native-access=ALL-UNNAMED"(no Vector API) and once with the default ("incubating APIs").SimdOperationsTestruns the scalar and the vector implementation in the same JVM and checks that they give identical results; it asserts that the module is present.
Requirements
- One property for the test JVM arguments, used by surefire, failsafe and the existing
coresecond pass. Default: the module stays off, as today. - A CI step (or matrix leg) that runs the unit and integration tests with the property set to add the module, so the Vector API kernels and the whole read/write path with them are covered. Keep the default leg.
- A differential test of
AutoVectorizedSimdOperationsagainstVectorApiSimdOperationsover all eleven ptypes in one JVM, skipped without the module. The documented divergences from Rust (lane-wise float sum, per-lane I64/U64 overflow, recorded indocs/compatibility.md) are compared explicitly, not hidden. - Remove the
without-vector-modulepass incore, or keep it only if the new property makes it meaningful.
Hardwood's files for reference: root pom.xml (test.argLine), .github/workflows/pr-build.yml, core/src/test/java/dev/hardwood/internal/encoding/simd/SimdOperationsTest.java.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed
Activity
build: CI leg that runs the tests without the Vector API module (#529)