Repository navigation
refactor(desktop): share relative timestamp formatting - #1445
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
ChangesRelative timestamp formatting
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to The shared formatter preserves the existing timestamp behavior. No merge blocker is identified; complete the planned hosted checks. Pre-merge checks |
|
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
|
@greptileai please review this pull request at current head e082da3. |
|
|
@greptileai please review the updated pull request at current head 6d59452. |
|
@coderabbitai full review Please review the current head 6d59452 after integration with main. |
✅ Action performedFull review finished. |
Both
timeAgoadapters duplicate the relative timestamp threshold ladder. Move it into a private elapsed-millisecond helper while preserving their guards, signatures, clock evaluation order/count, rounding, literals and edge-case behavior.formatTimestampand callers remain unchanged.Add frozen-clock regression tests through both public adapters for minute/hour/day boundaries, multiple days, future/epoch/negative/fractional values, invalid/nonfinite values, missing input and evaluation order.
Closes #1444
Validation on signed head
6d5945239fda317f04706f1229d471651a740c20, integrated with main56485803a98ccbf0505b1b42b8ecc12629ccfaf9:--version.The merge commit preserves published history and the exact original two-file patch. Fresh hosted reviews, CI, platform packaging and E2E are required for this head. Local Electron/native node-pty runtime dependencies remain unavailable after rebuild; no script policy was changed. Playwright's checked-in launch uses a mock CLI, so E2E alone does not validate the packaged real backend.
Summary by CodeRabbit