Repository navigation
feat(probe): compare direct and supervised runtime startup - #19
Merged
Merged
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (6)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing startup probe measures plain go-plugin launches and omits the supervisor introduced for process ownership. Add an optional
--supervisor-binarymode that measures the same Info and absent-workspace Find operations through the SDK supervisor, including both process launches and supervisor cleanup.Reports add launch mode and supervisor fingerprint metadata without removing schema-v1 fields. PID identifies the directly launched process (plugin or owning supervisor). Every successful sample must report a positive process ID and completed reaping. CI builds uninstrumented helpers and retains direct and supervised 100-sample reports together on Linux, macOS, and Windows.
Validation: full race suite and vet; direct/supervised real-executable tests including handshake timeout and invalid helper paths; strict lint and all-file prek; Windows probe test cross-compilation. Local macOS arm64 measurements run both orders, 100 warm samples per operation: direct p50 about 8–9 ms, supervised p50 about 17–18 ms, with every sample reaped.
These are warm-cache measurements, not cold-cache trials or acceptance thresholds. CI runs direct first, and documentation calls out ordering effects. A representative Devsy up trace and real-runtime compatibility remain prerequisites for selecting session reuse; this change introduces no pool or runtime cutover.
Local CodeRabbit reviewed the complete six-file diff with no findings. GitHub verified the signed commit.
CI comparison evidence (run 37148682418): each artifact contains raw direct and supervised reports from the same runner and runtime fingerprint. The reports record tested merge commit
4d132ddfc7f8491eccf0e2e54875df2171d23bcf, whose PR parent is91fa4abbab2f2f60daff4879a565a822897f0fab.All first/warm samples report a positive launch-owner PID and completed reaping. No cold-cache or session-reuse conclusion is claimed.
Final head
91fa4ab: all applicable CI checks passed; Release Please is correctly skipped on a PR event. Greptile review has been requested but no completed SDK review is available. Hosted CodeRabbit skips this draft; the complete local CodeRabbit review found no issues. Hosted reviewer gates remain incomplete, so this draft is not being declared merge-ready.