Repository navigation
test: probe runtime cancellation and process ownership - #14
Merged
Merged
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (6)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next host-hardening spike exercises real host/plugin/runtime-child ownership through the SDK's go-plugin/gRPC transport. The fixture launches a blocking child, acknowledges readiness before cancellation, answers independent liveness probes, and reports reaping only after
exec.Cmd.Waitreturns.The probes record two ownership gaps that must be resolved before runtime cutover:
Unary and Exec cancellation both reap the fixture child, including a child that ignores interruption. Unix asserts that the child received and ignored the signal before forced termination. Windows exercises the bounded forced-kill fallback because Go cannot deliver
os.Interruptto its child process there.Surviving processes are independently killed by the test observer, with retained process handles, and crash-left socket files are isolated in a short private temporary directory. The README explains the results and their limits. No public supervisor API or host lifetime policy is introduced; passing these tests records the transport's current gaps rather than certifying abrupt process-tree cleanup.
CI keeps the existing Linux/macOS/Windows race-test matrix and publishes
runtime-tests-*JSON artifacts for reviewable platform evidence. Bash pipe failure propagation preserves test failures when teeing the report.Local validation: full SDK race tests, vet, strict lint, prek, and diff checks passed. Local CodeRabbit identified an observer teardown backpressure issue; the fix was re-reviewed with zero findings. The last successful fresh committed review covered all six files with zero findings. A small event-routing extraction then brought the reader back within strict complexity limits; its final fresh CodeRabbit rerun was rate-limited (49-minute reset). The final source is validated with race tests, vet, and prek; the uncommitted workspace check is clean.
CI validation: run 37130756350 passed all three platform race/vet jobs, all startup probes, generated bindings, Lint, and Pre-commit. The saved JSON reports confirm all four cancellation combinations and both ownership-gap scenarios on Linux, macOS, and Windows. Release Please was skipped as expected for a pull request.