OMPI: Notified RMA ops Public API #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 8d7ea3b: Public APis to makefile
0b6b3c3: Public APIs for put_withnotify. get_with_notify
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
joe-explr
force-pushed
the
notified-rma-sm
branch
3 times, most recently
from
5a9c010 to
f79b94b
Compare
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 8ba738e: Edits
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
joe-explr
force-pushed
the
notified-rma-sm
branch
from
8ba738e to
80fef14
Compare
devreal
approved these changes
Nov 20, 2025
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: dff9ea5: Public APIs for:
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
joe-explr
force-pushed
the
notified-rma-sm
branch
from
dff9ea5 to
6519bd0
Compare
joe-explr
commented
Dec 5, 2025
joe-explr
commented
Dec 5, 2025
This commit adds notification support to the OSC SM component by implementing the put_with_notify, get_with_notify, rput_with_notify, and rget_with_notify functions. These functions perform the same operations as their non-notify counterparts but also increment notification counters after the data transfer completes. The changes include: - Added function pointer types for notify variants in osc.h - Added function prototypes in osc_sm.h - Implemented the notify functions in osc_sm_comm.c - Updated the module template to register the new functions - Removed TODO comments that have been addressed Signed-off-by: Joseph Antony <jajoseph.antony18@gmail.com>
Signed-off-by: Joseph Antony <jajoseph.antony18@gmail.com>
put_with_notify get_with_notify Signed-off-by: Joseph Antony <jajoseph.antony18@gmail.com>
put_with_notify
get_with_notify
Signed-off-by: Joseph Antony <jajoseph.antony18@gmail.com>
…for a single and multi rank window. Signed-off-by: Joseph Antony <jajoseph.antony18@gmail.com>
joe-explr
force-pushed
the
notified-rma-sm
branch
2 times, most recently
from
4e90525 to
f0ee69f
Compare
Signed-off-by: Joseph Antony <jajoseph.antony18@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes: