Skip to content

#2452: Fixed checkstyle violations in cli module - #2525

Open
laim2003 wants to merge 5 commits into
devonfw:mainfrom
laim2003:fix/2452-Solve-existing-checkstyle-violations-Module-cli
Open

laim2003 wants to merge 5 commits into
devonfw:mainfrom
laim2003:fix/2452-Solve-existing-checkstyle-violations-Module-cli

Conversation

@laim2003

@laim2003 laim2003 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #2452

Implemented changes:

  • Fixed checkstyle violations in cli module

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. cd cli
  2. mvn checkstyle:check
    Build should succeed

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summaries what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
    with internal
  • You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc
  • You have formulated clear instructions on how to test your contribution un

@laim2003 laim2003 added the internal Nothing to be added to CHANGELOG, only internal story label Sep 21, 2026
@coveralls

coveralls commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 35880448736

Coverage increased (+0.01%) to 74.105%

Details

  • Coverage increased (+0.01%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 60 coverage regressions across 8 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

60 previously-covered lines in 8 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/util/TruststoreUtil.java 20 75.71%
com/devonfw/tools/ide/merge/xml/XmlMerger.java 19 81.78%
com/devonfw/tools/ide/commandlet/TruststoreCommandlet.java 10 72.88%
com/devonfw/tools/ide/network/NetworkStatusImpl.java 5 73.08%
com/devonfw/tools/ide/version/VersionRangeRelation.java 3 72.92%
com/devonfw/tools/ide/tool/go/Go.java 1 66.67%
com/devonfw/tools/ide/util/PrivacyUtil.java 1 96.67%
com/devonfw/tools/ide/version/VersionSegment.java 1 91.34%

Coverage Stats

Coverage Status
Relevant Lines: 19120
Covered Lines: 14806
Line Coverage: 77.44%
Relevant Branches: 8565
Covered Branches: 5710
Branch Coverage: 66.67%
Branches in Coverage %: Yes
Coverage Strength: 3.32 hits per line

💛 - Coveralls

@laim2003 laim2003 moved this from 🆕 New to 🏗 In progress in IDEasy board Sep 21, 2026
@laim2003
laim2003 marked this pull request as ready for review September 21, 2026 15:30
@laim2003 laim2003 moved this from 🏗 In progress to Team Review in IDEasy board Sep 21, 2026
@JoelAdbu JoelAdbu self-assigned this Sep 22, 2026

@JoelAdbu JoelAdbu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👍.
I cloned your repository and checked out the branch of this PR. Running mvn checkstyle:checkstyle in cli module reports no violations.

@JoelAdbu JoelAdbu moved this from Team Review to 👀 In review in IDEasy board Sep 23, 2026
@laim2003
laim2003 requested a review from hohwille September 23, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Nothing to be added to CHANGELOG, only internal story

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

Solve existing checkstyle violations: Module cli

3 participants