Conversation
Coverage Report for CI Build 35201050434Coverage increased (+0.04%) to 74.199%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions10 previously-covered lines in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
quando632
left a comment
There was a problem hiding this comment.
Thanks for this one. It slots cleanly into GithubUrlReleaseUpdater instead of hand-rolling anything, the Javadoc explains the name vs. rust-v tag mismatch well, and the test covers all six OS/arch combinations plus both filter cases. I verified the six asset names against the real rust-v0.154.0 and rust-v0.112.0 releases, they match exactly.
Two points I would like to see addressed, details inline.
| protected String getGithubRepository() { | ||
| return "codex"; | ||
| } | ||
|
|
There was a problem hiding this comment.
/repos/openai/codex/releases is requested without per_page, so only the 30 most recent releases are seen, and openai/codex publishes 8 to 10 releases a day. On that page exactly one stable Rust CLI release survives mapVersion (0.155.0). The daily run in update-urls.yml keeps up with new releases, but versions outside the window are never backfilled, so codex would start out with a single version.
The suggestion raises the page size (same idea as page_size=50 in JavaUrlUpdater). The stub in CodexUrlUpdaterTest then needs get(urlPathEqualTo("/repos/openai/codex/releases")), because urlMatching also compares the query string; with that change the test passes.
| @Override | |
| protected String doGetVersionUrl() { | |
| return super.doGetVersionUrl() + "?per_page=100"; | |
| } | |
| */ | ||
| public class CodexUrlUpdater extends GithubUrlReleaseUpdater { | ||
|
|
||
| private static final VersionIdentifier MIN_CODEX_VID = VersionIdentifier.of("0.112.0"); |
There was a problem hiding this comment.
MIN_CODEX_VID drops everything below 0.112.0, although the assets exist earlier: rust-v0.111.0 carries the same set of codex-* assets, and the Linux and macOS tarballs go back to at least rust-v0.20.0. This becomes visible once the page size is raised, so documenting why the floor sits here (or lowering it) would help. The suggestion assumes the floor is intentional, please adjust the wording to the actual reason.
| private static final VersionIdentifier MIN_CODEX_VID = VersionIdentifier.of("0.112.0"); | |
| /** Oldest Codex CLI version offered by IDEasy (older releases exist but are intentionally not provided). */ | |
| private static final VersionIdentifier MIN_CODEX_VID = VersionIdentifier.of("0.112.0"); |
This PR fixes #2462
Implemented changes:
Testing instructions
cd ~/projects/_ide/urlsit checkout -b codex-testcd ~/projects/IDEasy/workspace/main/IDEasymvn -f url-updater/pom.xml exec:exec -Dexec.executable="java" -Dexec.args="-cp %classpath com.devonfw.tools.ide.url.UpdateInitiator /home/username/projects/_ide/urls /home/username/projects/_ide/tmp PT1H codex"Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc