#607: test that IDEA_PROPERTIES and STUDIO_PROPERTIES are set on the process context - #2490
majesteSil wants to merge 2 commits into
Conversation
Coverage Report for CI Build 35072660421Coverage increased (+0.01%) to 74.172%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
|
Thanks for your work, the tests are clear and pass for me locally. One suggestion I would add is to add a test that starts the tool. The tests as they are written now call My suggestion would be to change the mock scripts so they write the variable to a file, e.g. |
|
Thanks for the review @laert-ll !
So the unit tests pin the tool-specific definition (the real risk), and the generic plumbing is left to the existing run coverage, the same pattern ClaudeTest and SpyderTest use. If you see the process-level assertion as part of #607's acceptance criteria, I'm glad to add it the way you suggested (mock script writes echo "$IDEA_PROPERTIES" > ideaproperties, testIntellijRun/testAndroidStudioRun assert the file). |
This PR fixes #607
Implemented changes:
IntellijTest#testSetEnvironmentSetsIdeaPropertiesverifying thatsetEnvironmentputsIDEA_PROPERTIES(pointing toidea.propertiesin the workspace) into the environment context.AndroidStudioTest#testSetEnvironmentSetsStudioPropertiesverifying thatsetEnvironmentputsSTUDIO_PROPERTIES(pointing tostudio.propertiesin the workspace) into the environment context.Both use a
RecordingEnvironmentContextto capture the variables set on the process context, as requested in the issue.Testing instructions
Run the two new tests in the
climodule:mvn -Dtest='IntellijTest#testSetEnvironmentSetsIdeaProperties' testmvn -Dtest='AndroidStudioTest#testSetEnvironmentSetsStudioProperties' testBoth pass (verified locally, BUILD SUCCESS).
Checklist for this PR
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»In Progressand assigned to you or there is no issue (might happen for very small PRs)internal(issue Test for environment variables of process contexts #607 is labelledinternal, so no entry)pom.xmlfiles