Conversation
- added antigravity url updater - added test for antigravity url updater
- added agy url updater to UpdateManager
Coverage Report for CI Build 35607160010Warning No base build found for commit Coverage: 74.203%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
|
oh thanks @JoelAdbu for your clean work on this new UrlUpdater for Google Antigravity it looks very clean the new updater is faithful and conform to every documented Standard, even though i have some minor suggestions to improve the quality. the naming convention recommand to use plural so |
- review requests
|
@majesteSil Thanks for your review. I agree that UpdateManager currently lacks dedicated test coverage. However, this is a pre-existing concern and not specific for this PR, which only adds a new UrlUpdater following the established pattern. I would suggest - as you already have mentioned - to create a separate issue to discuss and implement appropriate UpdateManager tests. |
This PR fixes #2458
Implemented changes:
AgyUrlUpdaterAgyUrlUpdaterTestagy-release(mock for github-rest-api)Testing instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
AgyUrlUpdaterTestide-urls-statusrepository to/project/_ide/(if not already present):Note
You might run into GitHub API rate limits if you run the updater too frequently.
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc