Skip to content

#2458: Create url updater for antigravity - #2476

Open
JoelAdbu wants to merge 5 commits into
devonfw:mainfrom
JoelAdbu:feature/2458-create-url-updater-antigravity
Open

JoelAdbu wants to merge 5 commits into
devonfw:mainfrom
JoelAdbu:feature/2458-create-url-updater-antigravity

Conversation

@JoelAdbu

@JoelAdbu JoelAdbu commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #2458

Implemented changes:

  • Added AgyUrlUpdater
  • Added AgyUrlUpdaterTest
  • Added agy-release (mock for github-rest-api)

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. Run the newly added AgyUrlUpdaterTest
  2. Clone the ide-urls-status repository to /project/_ide/ (if not already present):
git clone https://github.com/devonfw/ide-urls-status.git
  1. Run UpdateInitiator with the following arguments:
<path-to-ide-urls> <path-to-ide-urls-status> PT10M agy
  1. Verify that the Anti Gravity (agy) versions are fetched and written to the status repository.

Note

You might run into GitHub API rate limits if you run the updater too frequently.


Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summaries what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
    with internal
  • You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

- added antigravity url updater
- added test for antigravity url updater
- added agy url updater to UpdateManager
@coveralls

coveralls commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 35607160010

Warning

No base build found for commit 4fee91a on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 74.203%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 19114
Covered Lines: 14820
Line Coverage: 77.53%
Relevant Branches: 8548
Covered Branches: 5706
Branch Coverage: 66.75%
Branches in Coverage %: Yes
Coverage Strength: 3.32 hits per line

💛 - Coveralls

@JoelAdbu JoelAdbu changed the title #2458: create url updater antigravity #2458: Create url updater for antigravity Sep 15, 2026
@JoelAdbu JoelAdbu added enhancement New feature or request urls ide-urls repo and related processes and features AI artificial intelligence, GenAI, etc. internal Nothing to be added to CHANGELOG, only internal story labels Sep 15, 2026
@JoelAdbu
JoelAdbu marked this pull request as ready for review September 15, 2026 11:46
@JoelAdbu JoelAdbu moved this from 🆕 New to Team Review in IDEasy board Sep 15, 2026
@majesteSil majesteSil self-assigned this Sep 16, 2026
@majesteSil

majesteSil commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

oh thanks @JoelAdbu for your clean work on this new UrlUpdater for Google Antigravity it looks very clean the new updater is faithful and conform to every documented Standard, even though i have some minor suggestions to improve the quality. the naming convention recommand to use plural so agy-releases.json instead of release.json and also Add // arrange marker to AgyUrlUpdaterTest you already refer other one (act and assert ).And last but not least though this is more of a question than a blocker for this PR, the UpdateManager. the central registry used by the URL update pipeline to orchestrate the ~54 updaters lacks its own test. The ~36 UrlUpdaterTest classes test the updaters in isolation; the UpdateManager itself is never executed directly. so i suggest not to solve this in this PR but to have a look on what is necessary for this Issue to do and ig it is a design and maybe create some Follow-up if needed

@majesteSil
majesteSil self-requested a review September 16, 2026 11:47
- review requests
@JoelAdbu

Copy link
Copy Markdown
Contributor Author

@majesteSil Thanks for your review. I agree that UpdateManager currently lacks dedicated test coverage. However, this is a pre-existing concern and not specific for this PR, which only adds a new UrlUpdater following the established pattern. I would suggest - as you already have mentioned - to create a separate issue to discuss and implement appropriate UpdateManager tests.

@JoelAdbu JoelAdbu moved this from Team Review to 👀 In review in IDEasy board Sep 17, 2026

@hohwille hohwille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoelAdbu thanks for your PR. Looks good to me and ready for merge👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI artificial intelligence, GenAI, etc. enhancement New feature or request internal Nothing to be added to CHANGELOG, only internal story urls ide-urls repo and related processes and features

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

Create UrlUpdater for antigravity

4 participants