#2347: GUI test duplicates view-setup code from App instead of reusing it - #2475
Open
Khaled-Cap wants to merge 4 commits into
Open
Khaled-Cap wants to merge 4 commits into
Khaled-Cap wants to merge 4 commits into
Conversation
Khaled-Cap
force-pushed
the
Issue2347
branch
from
September 15, 2026 08:00
80f6059 to
a1327ab
Compare
Collaborator
Coverage Report for CI Build 35232602398Coverage increased (+0.04%) to 74.202%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions23 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
…removed. The function loadMainView in App.java was turned into a static function.
# Conflicts: # CHANGELOG.adoc # Conflicts: # CHANGELOG.adoc
Khaled-Cap
force-pushed
the
Issue2347
branch
from
September 17, 2026 14:17
b2e6135 to
9e85f08
Compare
Khaled-Cap
marked this pull request as ready for review
September 17, 2026 14:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2347
Implemented changes:
Testing instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc