Skip to content

#2347: GUI test duplicates view-setup code from App instead of reusing it - #2475

Open
Khaled-Cap wants to merge 4 commits into
devonfw:mainfrom
Khaled-Cap:Issue2347
Open

Khaled-Cap wants to merge 4 commits into
devonfw:mainfrom
Khaled-Cap:Issue2347

Conversation

@Khaled-Cap

@Khaled-Cap Khaled-Cap commented Sep 15, 2026

Copy link
Copy Markdown

This PR fixes #2347

Implemented changes:

  • The function loadMainView() in App.java was changed to a static function with 3 Parameters: String ideRoot, GuiStateManager guiStateManager, NlsService nlsService.
  • The duplicates in AppBaseTest.start() were replaced with a call of the function loadMainView().

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. mvn clean install or simply run the tests in AppBaseTest.
  2. Optional: run the class com.devonfw.ide.gui.AppLauncher to make sure the Gui can still be started correctly.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summaries what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
    with internal
  • You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@CLAassistant

CLAassistant commented Sep 15, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Khaled-Cap Khaled-Cap added GUI Graphical User Interface of IDEasy (aka dashboard) build with JavaFx enhancement New feature or request labels Sep 15, 2026
@coveralls

coveralls commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 35232602398

Coverage increased (+0.04%) to 74.202%

Details

  • Coverage increased (+0.04%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 23 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

23 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/ide/gui/App.java 22 14.12%
com/devonfw/tools/ide/version/VersionSegment.java 1 90.55%

Coverage Stats

Coverage Status
Relevant Lines: 19002
Covered Lines: 14734
Line Coverage: 77.54%
Relevant Branches: 8516
Covered Branches: 5685
Branch Coverage: 66.76%
Branches in Coverage %: Yes
Coverage Strength: 3.31 hits per line

💛 - Coveralls

…removed. The function loadMainView in App.java was turned into a static function.
# Conflicts:
#	CHANGELOG.adoc

# Conflicts:
#	CHANGELOG.adoc
@Khaled-Cap
Khaled-Cap marked this pull request as ready for review September 17, 2026 14:18
@Khaled-Cap Khaled-Cap moved this from 🆕 New to Team Review in IDEasy board Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request GUI Graphical User Interface of IDEasy (aka dashboard) build with JavaFx

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

GUI test duplicates view-setup code from App instead of reusing it

3 participants