Skip to content

#2325: make Windows shortcuts configurable in MSI installer - #2474

Open
cap-juan wants to merge 1 commit into
devonfw:mainfrom
cap-juan:feature/2325-add-checkboxes-msi-installer
Open

cap-juan wants to merge 1 commit into
devonfw:mainfrom
cap-juan:feature/2325-add-checkboxes-msi-installer

Conversation

@cap-juan

@cap-juan cap-juan commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #2325

Implemented changes:

  • Added configurable checkboxes to the Windows MSI installer for creating Desktop and Start Menu shortcuts.
  • Shortcut creation is enabled by default to preserve the existing behavior.
  • Passed the selected MSI options to IDEasy and made shortcut creation conditional.
  • Added tests for enabled/disabled shortcut creation.

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

1- Build the native CLI: mvn -B -ntp -pl cli -am -Pnative package -DskipTests
2- Build the MSI installer: ./windows-installer/build-msi.sh
3- Run: windows-installer/ideasy.msi
4- Verify that the installer shows checkboxes for:
Desktop shortcut
Start Menu shortcut
5- Install once with both checkboxes enabled and verify both shortcuts are created.
6- Uninstall IDEasy, reinstall with both checkboxes disabled, and verify that neither shortcut is created.
7- Optionally verify mixed combinations, e.g. Desktop enabled and Start Menu disabled.


Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summaries what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
    with internal
  • You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

Checklist for tool commandlets

Have you added a new «tool» as commandlet? There are the following additional checks:

  • The tool can be installed automatically (during setup via settings) or via the commandlet call
  • The tool is isolated in its IDEasy project, see Sandbox Principle
  • The new tool is added to the table of tools in LICENSE.asciidoc
  • The new commandlet is a command-wrapper for «tool»
  • Proper help texts for all supported languages are added here
  • The new commandlet installs potential dependencies automatically
  • The variables «TOOL»_VERSION and «TOOL»_EDITION are honored by your commandlet
  • The new commandlet is tested on all platforms it is available for or tested on all platforms that are in scope of the linked issue

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Sep 14, 2026
@cap-juan cap-juan added enhancement New feature or request unpack logic to unpack archives (tar, zip, tgz, zbz2, msi, dmg, etc.) install installation process of IDE + tools and install commandlet labels Sep 14, 2026
@cap-juan cap-juan moved this from 🆕 New to Team Review in IDEasy board Sep 14, 2026
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 34852701645

Warning

No base build found for commit d94cbf8 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 73.94%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 18809
Covered Lines: 14532
Line Coverage: 77.26%
Relevant Branches: 8409
Covered Branches: 5593
Branch Coverage: 66.51%
Branches in Coverage %: Yes
Coverage Strength: 3.29 hits per line

💛 - Coveralls

@Khaled-Cap Khaled-Cap self-assigned this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request install installation process of IDE + tools and install commandlet unpack logic to unpack archives (tar, zip, tgz, zbz2, msi, dmg, etc.)

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

Add checkboxes for "Add to start desktop/taskbar" to MSI installer

3 participants