#2442: make windows-installer a maven module to align with macos-installer - #2444
Open
majesteSil wants to merge 2 commits into
Open
majesteSil wants to merge 2 commits into
majesteSil wants to merge 2 commits into
Conversation
…os-installer - add windows-installer/pom.xml (module ide-windows-installer, packaging pom, mirroring macos-installer) with a maven-clean-plugin fileset that removes the local MSI build artifacts (msi-files/, signed/, *.msi) - register the module in the root pom.xml <modules> - exclude ide-windows-installer from the release/nightly deploy (like ide-macos-installer) so the scaffolding module is not published - gitignore the windows-installer build outputs, mirroring the macOS section - note the change in CHANGELOG.adoc The MSI itself is still built by build-msi.sh (WixToolset is Windows-only and the payload is staged from the cli and documentation modules in the release job); this issue tracks the follow-up of moving that assembly into maven.
majesteSil
added
build
Collaborator
Coverage Report for CI Build 35106705135Coverage increased (+0.007%) to 74.165%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
|
@majesteSil Thanks for the PR! |
Contributor
Author
|
@Hiepiscus thanks for your Review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2442
Implemented changes:
windows-installer/pom.xmlpom.xml<modules>.ide-windows-installerfrom the release/nightlydeploystep (exactly likeide-macos-installeralready is) so this scaffolding module is not published to Maven Central.windows-installerbuild outputs (*.msi,msi-files/,signed/), mirroring theexisting
macos-installersection.Testing instructions
This is build scaffolding — no Java, and the MSI build path itself is unchanged. Verify:
mvn -q validate(ormvn -q validate -pl windows-installer) succeeds.windows-installer/pom.xmlmirrorsmacos-installer/pom.xml(same parent,pompackaging,clean filesets for the local build artifacts).
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»In Progressand assigned to youpom.xmlfilesChecklist for tool commandlets
Not applicable — no commandlet added.