#2344: align macOS PKG build script with Windows MSI build script - #2443
Open
majesteSil wants to merge 5 commits into
Open
majesteSil wants to merge 5 commits into
majesteSil wants to merge 5 commits into
Conversation
…te workflow references
…ADME, and CHANGELOG entry - document/contributing/coding-conventions.adoc: new 'Consistency' section encoding the homogeneity principle (build scripts next to what they build, follow existing layout, reuse Maven, mirror the counterpart for symmetry) - macos-installer/README.adoc: added, mirroring windows-installer/README.adoc - CHANGELOG.adoc: note the devonfw#2344 cleanup under the 2026.09.002 section
Collaborator
Coverage Report for CI Build 35106648194Coverage increased (+0.03%) to 74.183%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
majesteSil
changed the title
majesteSil
added
enhancement
Contributor
|
@majesteSil Thanks for the changes! Reviewed locally. Both workflows use the new path, and the checks passed. One small note: please clarify the command and working directory in the README. Running ./build-pkg.sh inside macos-installer fails with cd: documentation: No such file or directory. Running ./macos-installer/build-pkg.sh from the repository root starts the build correctly. Full PKG generation was not completed. Otherwise looks good to me. |
Contributor
Author
|
@shodiBoy1 thnaks for the comment i update the ReadMe so it done now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2344
Implemented changes:
.github/workflows/macos/generate_pkg.shtomacos-installer/build-pkg.shand updated the references inrelease.ymlandnightly-build.yml,Consistencysection to coding-conventions.adocmacos-installer/README.adocmirroringwindows-installer/README.adoc.Testing instructions
The change is a script move plus documentation and contains no Java code changes, so the test
suite is unaffected (CI still runs
mvn clean testas usual). To verify:grep -rn "generate_pkg" .github macos-installer→ no results.grep -rn "build-pkg.sh" .github/workflows→macos-installer/build-pkg.shinrelease.ymlandnightly-build.yml.Build MacOS PKGstep runs./macos-installer/build-pkg.shand producesmacos-installer/ideasy.pkgas before.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»In Progressand assigned to youpom.xmlfilesChecklist for tool commandlets
Not applicable — no commandlet added.