Skip to content

#2436 fixed plugin installation progress and removed duplicates of su… - #2441

Open
shodiBoy1 wants to merge 11 commits into
devonfw:mainfrom
shodiBoy1:feature/2436-fix-plugin-installation-progress
Open

shodiBoy1 wants to merge 11 commits into
devonfw:mainfrom
shodiBoy1:feature/2436-fix-plugin-installation-progress

Conversation

@shodiBoy1

@shodiBoy1 shodiBoy1 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #2436

Implemented changes:

  • Count only plugins that need installation. If two of three plugins are already installed, the remaining plugin now shows (1/1) instead of (2/3).
  • Remove duplicate success messages from Eclipse, IntelliJ, PyCharm and VS Code plugin installation.
  • Add tests for already installed plugins, inactive plugins, excluded editions, extra plugins and forced installation.

Testing instructions

  1. Check out this PR branch and open a terminal in the repository.

  2. Run the related tests:

    cd cli
    mvn -Dtest=PluginBasedCommandletTest,EclipseTest,IntellijTest,PycharmTest,VscodeTest,AndroidStudioTest test

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summaries what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
    with internal
  • You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@coveralls

coveralls commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 35770007564

Coverage remained the same at 74.091%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 31 coverage regressions across 4 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

31 previously-covered lines in 4 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/tool/ide/IdeaBasedIdeToolCommandlet.java 11 81.2%
com/devonfw/tools/ide/tool/plugin/PluginBasedCommandlet.java 11 88.16%
com/devonfw/tools/ide/tool/eclipse/Eclipse.java 5 68.35%
com/devonfw/tools/ide/tool/vscode/Vscode.java 4 84.91%

Coverage Stats

Coverage Status
Relevant Lines: 19113
Covered Lines: 14799
Line Coverage: 77.43%
Relevant Branches: 8561
Covered Branches: 5705
Branch Coverage: 66.64%
Branches in Coverage %: Yes
Coverage Strength: 3.32 hits per line

💛 - Coveralls

@shodiBoy1 shodiBoy1 added eclipse related to Eclipse IDE plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) step Logging and monitoring of process steps bugfix PR that fixes a bug issue labels Sep 13, 2026
@shodiBoy1
shodiBoy1 marked this pull request as ready for review September 13, 2026 20:46
@shodiBoy1 shodiBoy1 moved this from 🆕 New to Team Review in IDEasy board Sep 13, 2026
@JoelAdbu JoelAdbu self-assigned this Sep 14, 2026

@JoelAdbu JoelAdbu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I tested the changes locally and everything worked as expected. All tests passed successfully. I only have a few minor suggestions for improvement.

Comment thread cli/src/main/java/com/devonfw/tools/ide/tool/vscode/Vscode.java
Comment thread cli/src/main/java/com/devonfw/tools/ide/tool/plugin/PluginBasedCommandlet.java Outdated
@shodiBoy1

Copy link
Copy Markdown
Contributor Author

Nice work! I tested the changes locally and everything worked as expected. All tests passed successfully. I only have a few minor suggestions for improvement.

Thanks @JoelAdbu for the review and the catches. I applied both suggestions.

@shodiBoy1 shodiBoy1 moved this from Team Review to 👀 In review in IDEasy board Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes a bug issue eclipse related to Eclipse IDE plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) step Logging and monitoring of process steps

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

Plugin step progress index broken

3 participants