Conversation
c415a29 to
bfb3eca
Compare
Coverage Report for CI Build 34487872012Coverage increased (+0.004%) to 73.908%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
bfb3eca to
1abc8ad
Compare
1abc8ad to
9c51685
Compare
| Path workspacePath = this.context.getWorkspacePath(); | ||
| Path cwd = this.context.getCwd(); | ||
| pc.addArg(cwd.startsWith(workspacePath) ? cwd : workspacePath); |
There was a problem hiding this comment.
I understood issue #2393 and its kind of duplicate #2236 such that people wanted to open a separate git repo like settings in VSCode (or an other IDE of their choice).
However, IDEasy has an explicit feature that I do not have to explicitly do cd workspaces/main every time before I run my IDE since main is defined as the default workspace to open.
Therefore, if I am in $IDE_HOME or $IDE_HOME/workspaces I do not want to change the current behaviour and opening the entire project or workspaces folder is not what I personally would like to have.
Also I think that a lot of IDEasy users are used to this current behaviour and would get confused if that changes rather by accident.
Either we introduce an explicit option to open the current working directory regardless of what the derived workspace folder would be or we should only do this tweak if we are in an subfolder of my project unrelated to workspaces like settings what this feature was IMHO originally requested for.
BTW: Usually the idea is to first do a clarification of the story, then set the ready-to-implement label and then start a PR. Since we are already in that refinement now, I would also add that Eclipse has a totally different philosophy of a "workspace" that is totally unrelated to working directories since you can import any project from any location on your disc into the current workspace, so importing your settings folder can be done in any workspace of your choice like main or something else.
However, for IntelliJ or any JetBrains/IDEA based IDE the philosophy is similar to VSCode so maybe we want to change the behaviour for that in the same way to make it somehow more consistent.
This PR fixes #2236
Implemented changes:
ide vscodewas invoked.Testing instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
Build the native CLI:
mvn -B -ntp -pl cli -am -Pnative package -DskipTestsFrom Git Bash, navigate to a subdirectory, e.g.:
cd ~/Projects/IDEasy/workspaces/main/IDEasy/cliLaunch the freshly built IDEasy executable:
./target/ideasy.exe vscodeVerify that VS Code opens the current directory.
Open a new integrated terminal in VS Code and run:
pwdVerify that the terminal starts in the same directory from which
ide vscodewas launched.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidocChecklist for tool commandlets
Have you added a new
«tool»as commandlet? There are the following additional checks:«tool»«TOOL»_VERSIONand«TOOL»_EDITIONare honored by your commandlet