Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| #if os(iOS) || os(watchOS) | ||
| func testSeptember2026Devices() { | ||
| struct ExpectedDevice { |
There was a problem hiding this comment.
Types should be nested at most 1 level deepnesting Tests.swift:21 |
SwiftLint found issuesWarnings
Errors
Generated by 🚫 Danger |
Adapt PR #507, excluding iPhone Duo and the foldability API. Replace provisional identifiers with researched hardware mappings, including both iPhone 18 Pro Max regional variants. Add Apple technical specification links, display metrics, and device mapping regression coverage. Adapted from commit fe2c427.
Zandor300
force-pushed
the
t3code/add-apple-device-identifiers
branch
from
September 21, 2026 09:47
6de9551 to
338c9e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds automatic hardware detection for iPhone 18 Pro, iPhone 18 Pro Max, Apple Watch Series 12 (42mm/46mm), and Apple Watch Ultra 4. Adapts #507 while deferring iPhone Duo and its foldability API so the released models can ship independently.
iPhone19,2iPhone19,3,iPhone19,7Watch8,2,Watch8,4Watch8,3,Watch8,5Watch8,1Replaces provisional identifiers and display metrics, adds A20 Pro/S11 CPU cases, and links each device to Apple's technical specifications: iPhone 18 Pro, iPhone 18 Pro Max, Series 12, and Ultra 4. Watch display diagonals are calculated from Apple's published pixel dimensions and PPI, rounded to two decimal places.
Identifier sources: IPSW.me device API and Apple device identifier reports, checked September 21, 2026. Unverified identifiers remain unknown. Generated Swift and regression coverage are updated; existing device definitions are preserved.
Validation: