Conversation
…rops Previously read flat lowercase props from URL querystring (e.g. submitlabel, list). Now read data-* prefixed props consistent with all other embeddables (e.g. data-submit-label, data-list). Fixed newsletter submit() closure to read props["data-list"] and props["data-tag"] directly.
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the showcase and newsletter embeddables to consume configuration via data-* props (intended for the postMessage-based embedding flow) instead of flat, lowercase props previously sourced from URL query parameters.
Changes:
- Update showcase embeddable label/message props to read from
data-*keys (e.g.,data-success-message,data-submit-label). - Update newsletter embeddable to read list/tag and UI text from
data-*keys; adjust submit payload accordingly. - Add a changeset describing the embeddable prop-source alignment.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/dvz-ui/src/embeddable/showcase/index.jsx | Switches label/message props to data-* keys for embedding consistency. |
| packages/dvz-ui/src/embeddable/newsletter/index.jsx | Reads config from data-* props and updates submit to use data-list/data-tag. |
| .changeset/postmessage-embeddables.md | Documents the patch release and rationale for the embeddable prop changes. |
Comment on lines
18
to
29
| const { | ||
| status, | ||
| editing, | ||
| list, | ||
| placeholder = "enter your email address", | ||
| successmessage = "Thanks", | ||
| failuremessage = "Something didn't go well", | ||
| label = "Send", | ||
| tag, | ||
| "data-list": list, | ||
| "data-placeholder": placeholder = "enter your email address", | ||
| "data-success-message": successmessage = "Thanks", | ||
| "data-failure-message": failuremessage = "Something didn't go well", | ||
| "data-label": label = "Send", | ||
| "data-tag": tag, | ||
| email, | ||
| onChange | ||
| } = props |
…ing with navigation support
commit: |
timothygachengo
requested changes
Jul 1, 2026
| "@changesets/cli": "^2.29.7" | ||
| }, | ||
| "dependencies": { | ||
| "@devgateway/wp-react-lib": "link:packages/react-lib/wp-react-lib", |
Contributor
There was a problem hiding this comment.
Hello @sdimunzio We don't need @devgateway/wp-react-lib as a dependency in the root of the monorepo. @devgateway/dvz-ui-react already imports the wp-react-lib inside it as a dev dependency here:
data-viz-ui/packages/dvz-ui/package.json
Line 98 in 1f56d13
… height rendering
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
fix:)feat:)BREAKING CHANGE:)refactor:/chore:)docs:)Affected package(s)
@devgateway/dvz-ui-react@devgateway/wp-react-libexampleonly (no changeset needed)Checklist
pnpm changeset) for any change to a published packagepnpm buildpasses locally