AMP-31133 : Indicator values display fixes#198
Open
brianbrix wants to merge 3 commits into
Open
Conversation
…s~program) getFieldDef used i += 2 in the loop body which consumed two path parts per iteration (the for-loop's own i++ added a third advance). For a 3-part path like 'national_plan_objective~indirect_programs~program', only parts[0] and parts[1] were processed, returning the definition for 'indirect_programs' instead of 'program'. Since 'indirect_programs' has no id_only: true, the HydratorHelper in reamp never collected indirect program IDs, so the id-values POST request never included 'national_plan_objective~indirect_programs~program', and hence that key was absent from the id-values response. Fix: traverse one level at a time. Each iteration finds the current part in the current list, advances the list to that definition's children if needed, and moves to the next part. Correctly handles paths of any depth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.