Repository navigation
refactor: simplify rename and document the page reset (LUI-180) - #16
Merged
Merged
Conversation
O renomear devolve a linha na mesma consulta (updateManyAndReturn), e createFolder e renameItem passam a dividir o corpo comum. O LLD registra que o diálogo de renomear descarta as páginas acrescentadas por "Carregar mais". Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ANcDtWf5vRMzv1r42Ax9ce
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
No open issues 🎉
What changed in this PR
Refactors rename handling without changing behavior and documents pagination reset semantics.
Changes:
- Shares validation and error handling between folder creation and renaming.
- Uses
updateManyAndReturnfor atomic renames. - Documents resetting loaded pages after renaming.
| File | Description |
|---|---|
docs/lld.md |
Documents pagination behavior after renaming. |
apps/web/app/(drive)/actions.ts |
Consolidates folder creation and rename logic. |
apps/api/src/modules/items/items.repository.ts |
Returns the renamed item from the update query. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumo
Ajustes de limpeza do renomear (LUI-180), que saíram do
/simplifydepois que a PR #15 já tinha sido mergeada:ItemsRepository.renameActivedevolve a linha na mesma consulta (updateManyAndReturn, como oclaimPendingUploadjá faz), em vez deupdateManymais uma leitura. Continua atômico.createFoldererenameItem(Server Actions) dividem o corpo comum emrunNameAction, eRenameItemResulté alias deCreateFolderResult.docs/lld.md("Paginação das listas") registra que o diálogo de renomear descarta as páginas acrescentadas por "Carregar mais" e volta à primeira página do servidor.Aceite
nenhum: refatoração sem mudança de comportamento; os critérios da LUI-180 já foram entregues pela PR #15.
🤖 Generated with Claude Code