Repository navigation
fix(harness): isolar HARNESS_HEAD_REF no teste do modo review - #14
Merged
Merged
Conversation
On a pull request the CI exports HARNESS_HEAD_REF with the branch SHA, and the review test inherited it into its temporary repository, which has no such commit, so 20 cases failed on every PR. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
0 open findings
What changed in this PR
Updates the review-mode harness test to prevent CI’s HARNESS_HEAD_REF from affecting temporary repositories.
Changes:
- Unsets
HARNESS_HEAD_REFwhen invokingverify.sh review.
| File | Description |
|---|---|
scripts/test/verify-review.test.sh |
Isolates review-mode tests from inherited CI state. |
🧠 Review effort: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que muda
Uma linha em
scripts/test/verify-review.test.sh: a funçãoreview()passa a rodar overify.shcom-u HARNESS_HEAD_REF.Na CI de pull request, o workflow exporta
HARNESS_HEAD_REFcom o SHA da branch. O teste herdava a variável no repositório temporário dele, que não tem esse commit, e 20 casos do modoreviewfalhavam em todo PR (foi o que reprovou o Veredito do #12 e do #13). Em push namaina variável fica vazia, e por isso amainpassava.Aviso do harness
Este PR altera
scripts/, então o checkGuarda do harnesso reprova e ele só entra por override do usuário.Aceite
nenhum: mudança no harness, sem mudança de comportamento do produto.
🤖 Generated with Claude Code