Skip to content

fix(devframe): stop mcp-http tests from sharing a port #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antfu merged 1 commit into from
Jul 10, 2026
Merged

fix(devframe): stop mcp-http tests from sharing a port #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/devframe/src/adapters/mcp/__tests__/mcp-http.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,15 @@ describe('mcp adapter (streamable http route)', () => {
})

async function boot(def = defineTestDef()): Promise<StartedServer> {
server = await createDevServer(def, { host: '127.0.0.1', mcp: true })
// `port: 0` lets the OS assign a fresh ephemeral port per test. Without
// it every test binds the same default port, and since they all share
// one process, Node's global `fetch()` (undici) pools keep-alive
// sockets per origin (`http://127.0.0.1:<port>`) — a later test can get
// handed a stale, already-closed socket left over from an earlier
// test's (torn-down) server, failing instantly with a socket error, or
// making that earlier server's `close()` hang until undici's
// keep-alive timeout releases it.
server = await createDevServer(def, { host: '127.0.0.1', port: 0, mcp: true })
return server
}

Expand All @@ -47,7 +55,7 @@ describe('mcp adapter (streamable http route)', () => {
})

it('omits the mcp block when the route is disabled', async () => {
server = await createDevServer(defineTestDef(), { host: '127.0.0.1', mcp: false })
server = await createDevServer(defineTestDef(), { host: '127.0.0.1', port: 0, mcp: false })
const res = await fetch(`${server.origin}/__connection.json`)
const meta = await res.json() as { mcp?: unknown }
expect(meta.mcp).toBeUndefined()
Expand Down
Loading