Skip to content

fix: restore green CI after deps bump - #389

Merged
antfu merged 1 commit into
mainfrom
fluffy-steaks-sleep
Sep 14, 2026
Merged

antfu merged 1 commit into
mainfrom
fluffy-steaks-sleep

Conversation

@antfubot

Copy link
Copy Markdown
Collaborator

Why

CI has been red on main since the last dependency bump (vite 8.2→8.3, unocss 66.10.0→66.10.2). Two independent failures:

  • Type Check — every example that imports design/uno.config.ts failed with Type 'Preset<object>' is not assignable to type 'Preset<any>'. The unocss bump left @antfu/design's optional @unocss/core peer resolving to a stale 66.10.0 while the workspace moved to 66.10.2, so two structurally-identical-but-nominally-distinct copies of the unocss types made presetAnthonyDesign() unassignable.
  • Unit Test@devframes/hub-ui defines the viewer background through a static token failed because Vite 8.3 now minifies the standalone viewer's inline <style> (dropping the spaces the assertions matched, e.g. color-scheme: lightcolor-scheme:light).

What

  • Pin @unocss/core to the existing unocss override so a single copy resolves across the workspace.
  • Match the hub-ui background assertions against the inline CSS with whitespace stripped, so they're robust to the build minifying the <style>.

All gates pass locally: pnpm lint && pnpm knip && pnpm test && pnpm typecheck && pnpm build.

This PR was created with the help of an agent.

The deps bump to unocss 66.10.2 left @antfu/design's optional
@unocss/core peer resolving to a stale 66.10.0, so the two copies of
its types made presetAnthonyDesign() unassignable in design/uno.config.ts
and broke every example typecheck. Pin @unocss/core to the unocss
override so one copy resolves.

Vite 8.3 also minifies the standalone viewer's inline <style>, so the
hub-ui background test now matches the CSS with whitespace stripped
instead of its authored spacing.
@coldtea-pr-lens

coldtea-pr-lens Bot commented Sep 14, 2026

Copy link
Copy Markdown

◈ PR Lens

🟢 +0 new · 🟠 ~1 changed · 🔴 -0 removed · 0 flows · 1 file · commit 105bcc9


Architecture

Architecture diagram for devframes/devframe at 105bcc9

1 component touched across 3 lanes.

Open the interactive canvas


Data flow

No data-flow sequence changed in this PR.


View

  • Architecture lens
  • Data flow lens
  • Expand every detail

Tip

The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change.

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists.
  • Untick Architecture lens or Data flow lens under View to hide a diagram, or tick Expand every detail to open every section. The comment redraws in a few seconds.
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through.
  • Open a diagram on the canvas, then press W or click play to walk through the change one step at a time.
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time.
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture and data flow row. Drawing still runs on every push.
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works.
  • Push a commit and the comment redraws for the new head. A slow older run never overwrites a newer one.
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion.

Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
devframe Ready Ready Preview Sep 14, 2026 6:16am UTC

@antfu
antfu merged commit f314d02 into main Sep 14, 2026
14 checks passed
@antfu
antfu deleted the fluffy-steaks-sleep branch September 14, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants