ci: add ecosystem test against vitejs/devtools#23
Merged
Conversation
Pack the local devframe build, clone vitejs/devtools at its latest released tag, override its devframe dependency via pnpm.overrides, and run the downstream install/build/test to catch regressions before release. Triggered manually (with an optional ref input) or on a weekly schedule.
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Adds an “ecosystem CI” check to validate devframe against the downstream project vitejs/devtools, helping catch integration regressions early.
Changes:
- Introduces
scripts/ecosystem-ci.tsto pack the localdevframe, clonevitejs/devtools, override itsdevframedependency to the local tarball, and run downstream install/build/test. - Adds a scheduled + manual GitHub Actions workflow to run the ecosystem check and upload downstream logs on failure.
- Wires a
pnpm test:ecosystemscript and ignores the generated.ecosystem/workspace.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/ecosystem-ci.ts | Implements the pack/clone/override + downstream install/build/test runner. |
| .github/workflows/ecosystem-ci.yml | Adds scheduled + manual workflow to run the ecosystem CI job and upload artifacts on failure. |
| package.json | Adds test:ecosystem script entrypoint for the new runner. |
| .gitignore | Ignores generated .ecosystem/ workspace directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (existsSync(devtoolsDir)) | ||
| rmSync(devtoolsDir, { recursive: true, force: true }) | ||
|
|
||
| run('git', ['clone', '--depth', '1', '--branch', ref, REPO_URL, devtoolsDir]) |
| workflow_dispatch: | ||
| inputs: | ||
| ref: | ||
| description: 'vitejs/devtools ref to test against (tag, branch, or commit). Defaults to latest released tag.' |
Comment on lines
+110
to
+111
| throw new Error( | ||
| `Command failed (exit ${result.status ?? 'unknown'}): ${cmd} ${args.join(' ')}`, |
Switch from `git clone --branch` to `git init` + `git fetch --depth 1` so the workflow's `ref` input accepts commit SHAs (as the description already advertises), and include `result.error` / `result.signal` in the thrown message so spawn failures are diagnosable. Addresses Copilot review on #23.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/ecosystem-ci.tspacks the localdevframebuild, clonesvitejs/devtoolsat its latest released tag (overridable viaECOSYSTEM_DEVTOOLS_REF), patchespnpm.overrides.devframein the clone to point at the local tarball, then runspnpm install --no-frozen-lockfile && pnpm build && pnpm testinside it..github/workflows/ecosystem-ci.ymlruns the script onworkflow_dispatch(with an optionalrefinput) and on a weekly Monday schedule; failures upload downstream logs as artifacts.pnpm test:ecosystemand added.ecosystem/to.gitignore.Test plan
pnpm test:ecosystemlocally and confirmvitejs/devtools@<latest>install/build/test succeeds against HEAD.gh workflow run ecosystem-ci.ymlonce the workflow lands on main; verify a green run and that therefinput works (e.g.-f ref=v0.2.0).