Skip to content

Comments

chore: update Go toolchain to 1.25.7#1574

Open
akurinnoy wants to merge 3 commits intodevfile:mainfrom
akurinnoy:update-golang-1.25
Open

chore: update Go toolchain to 1.25.7#1574
akurinnoy wants to merge 3 commits intodevfile:mainfrom
akurinnoy:update-golang-1.25

Conversation

@akurinnoy
Copy link
Collaborator

@akurinnoy akurinnoy commented Jan 19, 2026

What does this PR do?

update Go toolchain to 1.25.5

What issues does this PR fix or reference?

resolves #1566

Is it tested? How?

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

@akurinnoy akurinnoy marked this pull request as draft January 19, 2026 14:48
@akurinnoy
Copy link
Collaborator Author

/retest

@akurinnoy akurinnoy changed the title chore: update Go toolchain to 1.25.3 chore: update Go toolchain to 1.25.5 Feb 16, 2026
@akurinnoy akurinnoy marked this pull request as ready for review February 16, 2026 17:51
@akurinnoy akurinnoy requested a review from tolusha February 17, 2026 08:30
@rohanKanojia
Copy link
Member

@akurinnoy : Sorry for the late request again 🙏

I noticed that Badre recently bumped downstream DWO to Go 1.25.6 to address some Go CVEs.

Would it be possible to also bump the image to the latest available version to ensure we’re aligned and fully covered from a security perspective? https://catalog.redhat.com/en/software/containers/ubi9/go-toolset/61e5c00b4ec9945c18787690?image=699436919e1c8615b07d8f46

@openshift-ci openshift-ci bot removed the lgtm label Feb 19, 2026
@akurinnoy akurinnoy changed the title chore: update Go toolchain to 1.25.5 chore: update Go toolchain to 1.25.7 Feb 19, 2026
@akurinnoy
Copy link
Collaborator Author

@rohanKanojia I updated the pull request with the latest go-toolset available, please take a look one more time

@openshift-ci openshift-ci bot added the lgtm label Feb 19, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, rohanKanojia, tolusha
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rohanKanojia
Copy link
Member

@akurinnoy : Thanks a lot for quickly making these changes 👍 ! Let's try to get it merged.

@akurinnoy
Copy link
Collaborator Author

/retest

@akurinnoy
Copy link
Collaborator Author

/retest-required

@rohanKanojia
Copy link
Member

@akurinnoy : strange, e2e test pipeline is failure due to this error, if when you bumped the image version to 1.25:

go: go.mod requires go >= 1.25.0 (running go 1.24.4; GOTOOLCHAIN=local)

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Feb 19, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 19, 2026

New changes are detected. LGTM label has been removed.

@akurinnoy
Copy link
Collaborator Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 19, 2026

@akurinnoy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-images 86a6f3e link true /test v14-images
ci/prow/v14-che-happy-path 86a6f3e link true /test v14-che-happy-path
ci/prow/v14-devworkspace-operator-e2e 86a6f3e link true /test v14-devworkspace-operator-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update project to go 1.25

3 participants